Christopher Haster
75f80aabd7
This adds two new configuration options: erase_size and erase_count,
allowing block_size and block_count to be loaded from the superblock
during mount. For backwards compability these default to block_size and
block_count if zero.
---
Unfortunately this is a bit easier said than done. littlefs keeps its
superblock in the metadata pair located at blocks {0,1}, which is also
where the root directory lives (keep in mind small littlefs images may
only have 2 blocks in total). If we mutate blocks {0,1}, we have to
erase before programming, which means it's possible to have the only
superblock in block 1. This presents a puzzle because how do you find
block 1 if you don't know the size of a block?
One solution presented here is to search for block 1 by trying different
sizes until we find a superblock. This isn't great but there are some
properties of this search that help:
1. If we do find a superblock, the search will never take longer than a
mount with a known block_size. This is because we stop at block 1,
searching at most O(block_size) bytes, and metadata fetch is already
a O(block_size) operation.
This means the concern is limited to how long it takes to fail when
littlefs is not present on the disk.
2. We can assume the on-disk block_size is probably a factor of the
total size of the disk. After a bit of digging into the math, this
apparently reduces the runtime to the divisor function, d(n), which
is sublinear.
According to a blog post by Terence Tao this is bounded by the
ridiculous O(e^O(log(n)/log(log(n)))):
https://terrytao.wordpress.com/2008/09/23/the-divisor-bound
This is apparently somewhere between O(sqrt(n)) and O(log(n)), but
conveniently O(log(n)) on average and O(log(n)) for powers of 2.
I've left it as O(d(n)) in the documentation, which might be a bit
confusing, but I'm not sure how best to capture "mostly log(n)"
correctly.
3. If we don't know the block_size, or don't know that block_size is
aligned to the disk size, the best we can do is a O(n) search.
In this case I've added a warning, so at least it's distinguishable
from an infinite loop if debugging.
261 lines
7.8 KiB
TOML
261 lines
7.8 KiB
TOML
# bad blocks with block cycles should be tested in test_relocations
|
|
if = '(int32_t)BLOCK_CYCLES == -1'
|
|
|
|
[cases.test_badblocks_single]
|
|
defines.BLOCK_COUNT = 256 # small bd so test runs faster
|
|
defines.ERASE_CYCLES = 0xffffffff
|
|
defines.ERASE_VALUE = [0x00, 0xff, -1]
|
|
defines.BADBLOCK_BEHAVIOR = [
|
|
'LFS_EMUBD_BADBLOCK_PROGERROR',
|
|
'LFS_EMUBD_BADBLOCK_ERASEERROR',
|
|
'LFS_EMUBD_BADBLOCK_READERROR',
|
|
'LFS_EMUBD_BADBLOCK_PROGNOOP',
|
|
'LFS_EMUBD_BADBLOCK_ERASENOOP',
|
|
]
|
|
defines.NAMEMULT = 64
|
|
defines.FILEMULT = 1
|
|
code = '''
|
|
for (lfs_block_t badblock = 2; badblock < BLOCK_COUNT; badblock++) {
|
|
lfs_emubd_setwear(cfg, badblock-1, 0) => 0;
|
|
lfs_emubd_setwear(cfg, badblock, 0xffffffff) => 0;
|
|
|
|
lfs_t lfs;
|
|
lfs_format(&lfs, cfg) => 0;
|
|
|
|
lfs_mount(&lfs, cfg) => 0;
|
|
for (int i = 1; i < 10; i++) {
|
|
uint8_t buffer[1024];
|
|
for (int j = 0; j < NAMEMULT; j++) {
|
|
buffer[j] = '0'+i;
|
|
}
|
|
buffer[NAMEMULT] = '\0';
|
|
lfs_mkdir(&lfs, (char*)buffer) => 0;
|
|
|
|
buffer[NAMEMULT] = '/';
|
|
for (int j = 0; j < NAMEMULT; j++) {
|
|
buffer[j+NAMEMULT+1] = '0'+i;
|
|
}
|
|
buffer[2*NAMEMULT+1] = '\0';
|
|
lfs_file_t file;
|
|
lfs_file_open(&lfs, &file, (char*)buffer,
|
|
LFS_O_WRONLY | LFS_O_CREAT) => 0;
|
|
|
|
lfs_size_t size = NAMEMULT;
|
|
for (int j = 0; j < i*FILEMULT; j++) {
|
|
lfs_file_write(&lfs, &file, buffer, size) => size;
|
|
}
|
|
|
|
lfs_file_close(&lfs, &file) => 0;
|
|
}
|
|
lfs_unmount(&lfs) => 0;
|
|
|
|
lfs_mount(&lfs, cfg) => 0;
|
|
for (int i = 1; i < 10; i++) {
|
|
uint8_t buffer[1024];
|
|
for (int j = 0; j < NAMEMULT; j++) {
|
|
buffer[j] = '0'+i;
|
|
}
|
|
buffer[NAMEMULT] = '\0';
|
|
struct lfs_info info;
|
|
lfs_stat(&lfs, (char*)buffer, &info) => 0;
|
|
info.type => LFS_TYPE_DIR;
|
|
|
|
buffer[NAMEMULT] = '/';
|
|
for (int j = 0; j < NAMEMULT; j++) {
|
|
buffer[j+NAMEMULT+1] = '0'+i;
|
|
}
|
|
buffer[2*NAMEMULT+1] = '\0';
|
|
lfs_file_t file;
|
|
lfs_file_open(&lfs, &file, (char*)buffer, LFS_O_RDONLY) => 0;
|
|
|
|
int size = NAMEMULT;
|
|
for (int j = 0; j < i*FILEMULT; j++) {
|
|
uint8_t rbuffer[1024];
|
|
lfs_file_read(&lfs, &file, rbuffer, size) => size;
|
|
memcmp(buffer, rbuffer, size) => 0;
|
|
}
|
|
|
|
lfs_file_close(&lfs, &file) => 0;
|
|
}
|
|
lfs_unmount(&lfs) => 0;
|
|
}
|
|
'''
|
|
|
|
[cases.test_badblocks_region_corruption] # (causes cascading failures)
|
|
defines.BLOCK_COUNT = 256 # small bd so test runs faster
|
|
defines.ERASE_CYCLES = 0xffffffff
|
|
defines.ERASE_VALUE = [0x00, 0xff, -1]
|
|
defines.BADBLOCK_BEHAVIOR = [
|
|
'LFS_EMUBD_BADBLOCK_PROGERROR',
|
|
'LFS_EMUBD_BADBLOCK_ERASEERROR',
|
|
'LFS_EMUBD_BADBLOCK_READERROR',
|
|
'LFS_EMUBD_BADBLOCK_PROGNOOP',
|
|
'LFS_EMUBD_BADBLOCK_ERASENOOP',
|
|
]
|
|
defines.NAMEMULT = 64
|
|
defines.FILEMULT = 1
|
|
code = '''
|
|
for (lfs_block_t i = 0; i < (BLOCK_COUNT-2)/2; i++) {
|
|
lfs_emubd_setwear(cfg, i+2, 0xffffffff) => 0;
|
|
}
|
|
|
|
lfs_t lfs;
|
|
lfs_format(&lfs, cfg) => 0;
|
|
|
|
lfs_mount(&lfs, cfg) => 0;
|
|
for (int i = 1; i < 10; i++) {
|
|
uint8_t buffer[1024];
|
|
for (int j = 0; j < NAMEMULT; j++) {
|
|
buffer[j] = '0'+i;
|
|
}
|
|
buffer[NAMEMULT] = '\0';
|
|
lfs_mkdir(&lfs, (char*)buffer) => 0;
|
|
|
|
buffer[NAMEMULT] = '/';
|
|
for (int j = 0; j < NAMEMULT; j++) {
|
|
buffer[j+NAMEMULT+1] = '0'+i;
|
|
}
|
|
buffer[2*NAMEMULT+1] = '\0';
|
|
lfs_file_t file;
|
|
lfs_file_open(&lfs, &file, (char*)buffer,
|
|
LFS_O_WRONLY | LFS_O_CREAT) => 0;
|
|
|
|
lfs_size_t size = NAMEMULT;
|
|
for (int j = 0; j < i*FILEMULT; j++) {
|
|
lfs_file_write(&lfs, &file, buffer, size) => size;
|
|
}
|
|
|
|
lfs_file_close(&lfs, &file) => 0;
|
|
}
|
|
lfs_unmount(&lfs) => 0;
|
|
|
|
lfs_mount(&lfs, cfg) => 0;
|
|
for (int i = 1; i < 10; i++) {
|
|
uint8_t buffer[1024];
|
|
for (int j = 0; j < NAMEMULT; j++) {
|
|
buffer[j] = '0'+i;
|
|
}
|
|
buffer[NAMEMULT] = '\0';
|
|
struct lfs_info info;
|
|
lfs_stat(&lfs, (char*)buffer, &info) => 0;
|
|
info.type => LFS_TYPE_DIR;
|
|
|
|
buffer[NAMEMULT] = '/';
|
|
for (int j = 0; j < NAMEMULT; j++) {
|
|
buffer[j+NAMEMULT+1] = '0'+i;
|
|
}
|
|
buffer[2*NAMEMULT+1] = '\0';
|
|
lfs_file_t file;
|
|
lfs_file_open(&lfs, &file, (char*)buffer, LFS_O_RDONLY) => 0;
|
|
|
|
lfs_size_t size = NAMEMULT;
|
|
for (int j = 0; j < i*FILEMULT; j++) {
|
|
uint8_t rbuffer[1024];
|
|
lfs_file_read(&lfs, &file, rbuffer, size) => size;
|
|
memcmp(buffer, rbuffer, size) => 0;
|
|
}
|
|
|
|
lfs_file_close(&lfs, &file) => 0;
|
|
}
|
|
lfs_unmount(&lfs) => 0;
|
|
'''
|
|
|
|
[cases.test_badblocks_alternating_corruption] # (causes cascading failures)
|
|
defines.BLOCK_COUNT = 256 # small bd so test runs faster
|
|
defines.ERASE_CYCLES = 0xffffffff
|
|
defines.ERASE_VALUE = [0x00, 0xff, -1]
|
|
defines.BADBLOCK_BEHAVIOR = [
|
|
'LFS_EMUBD_BADBLOCK_PROGERROR',
|
|
'LFS_EMUBD_BADBLOCK_ERASEERROR',
|
|
'LFS_EMUBD_BADBLOCK_READERROR',
|
|
'LFS_EMUBD_BADBLOCK_PROGNOOP',
|
|
'LFS_EMUBD_BADBLOCK_ERASENOOP',
|
|
]
|
|
defines.NAMEMULT = 64
|
|
defines.FILEMULT = 1
|
|
code = '''
|
|
for (lfs_block_t i = 0; i < (BLOCK_COUNT-2)/2; i++) {
|
|
lfs_emubd_setwear(cfg, (2*i) + 2, 0xffffffff) => 0;
|
|
}
|
|
|
|
lfs_t lfs;
|
|
lfs_format(&lfs, cfg) => 0;
|
|
|
|
lfs_mount(&lfs, cfg) => 0;
|
|
for (int i = 1; i < 10; i++) {
|
|
uint8_t buffer[1024];
|
|
for (int j = 0; j < NAMEMULT; j++) {
|
|
buffer[j] = '0'+i;
|
|
}
|
|
buffer[NAMEMULT] = '\0';
|
|
lfs_mkdir(&lfs, (char*)buffer) => 0;
|
|
|
|
buffer[NAMEMULT] = '/';
|
|
for (int j = 0; j < NAMEMULT; j++) {
|
|
buffer[j+NAMEMULT+1] = '0'+i;
|
|
}
|
|
buffer[2*NAMEMULT+1] = '\0';
|
|
lfs_file_t file;
|
|
lfs_file_open(&lfs, &file, (char*)buffer,
|
|
LFS_O_WRONLY | LFS_O_CREAT) => 0;
|
|
|
|
lfs_size_t size = NAMEMULT;
|
|
for (int j = 0; j < i*FILEMULT; j++) {
|
|
lfs_file_write(&lfs, &file, buffer, size) => size;
|
|
}
|
|
|
|
lfs_file_close(&lfs, &file) => 0;
|
|
}
|
|
lfs_unmount(&lfs) => 0;
|
|
|
|
lfs_mount(&lfs, cfg) => 0;
|
|
for (int i = 1; i < 10; i++) {
|
|
uint8_t buffer[1024];
|
|
for (int j = 0; j < NAMEMULT; j++) {
|
|
buffer[j] = '0'+i;
|
|
}
|
|
buffer[NAMEMULT] = '\0';
|
|
struct lfs_info info;
|
|
lfs_stat(&lfs, (char*)buffer, &info) => 0;
|
|
info.type => LFS_TYPE_DIR;
|
|
|
|
buffer[NAMEMULT] = '/';
|
|
for (int j = 0; j < NAMEMULT; j++) {
|
|
buffer[j+NAMEMULT+1] = '0'+i;
|
|
}
|
|
buffer[2*NAMEMULT+1] = '\0';
|
|
lfs_file_t file;
|
|
lfs_file_open(&lfs, &file, (char*)buffer, LFS_O_RDONLY) => 0;
|
|
|
|
lfs_size_t size = NAMEMULT;
|
|
for (int j = 0; j < i*FILEMULT; j++) {
|
|
uint8_t rbuffer[1024];
|
|
lfs_file_read(&lfs, &file, rbuffer, size) => size;
|
|
memcmp(buffer, rbuffer, size) => 0;
|
|
}
|
|
|
|
lfs_file_close(&lfs, &file) => 0;
|
|
}
|
|
lfs_unmount(&lfs) => 0;
|
|
'''
|
|
|
|
# other corner cases
|
|
[cases.test_badblocks_superblocks] # (corrupt 1 or 0)
|
|
defines.ERASE_CYCLES = 0xffffffff
|
|
defines.ERASE_VALUE = [0x00, 0xff, -1]
|
|
defines.BADBLOCK_BEHAVIOR = [
|
|
'LFS_EMUBD_BADBLOCK_PROGERROR',
|
|
'LFS_EMUBD_BADBLOCK_ERASEERROR',
|
|
'LFS_EMUBD_BADBLOCK_READERROR',
|
|
'LFS_EMUBD_BADBLOCK_PROGNOOP',
|
|
'LFS_EMUBD_BADBLOCK_ERASENOOP',
|
|
]
|
|
code = '''
|
|
lfs_emubd_setwear(cfg, 0, 0xffffffff) => 0;
|
|
lfs_emubd_setwear(cfg, 1, 0xffffffff) => 0;
|
|
|
|
lfs_t lfs;
|
|
lfs_format(&lfs, cfg) => LFS_ERR_NOSPC;
|
|
lfs_mount(&lfs, cfg) => LFS_ERR_INVAL;
|
|
'''
|