Github/littlefs
1
Fork 0
Code Actions Activity

ckparity: Don't check parity when incrementing revision count

Browse Source 
It doesn't really matter, since any bit-errors will be thrown out during
fetch anyways, but checking the parity of revision counts is technically
the wrong thing to do if we care about compatibility with non-ckparity
builds.

Note this lfsr_bd_readck call was immediately followed by ignoring the
LFS_ERR_CORRUPT error and defaulting the revision count to zero.

Thanks allowing lfsr_bd_readck to be more aggressively inlined, this
saves both code and stack:

                    code          stack
  default before:  36412           2616
  default after:   36412 (+0.0%)   2616 (+0.0%)

  ckparity before: 37972           3088
  ckparity after:  37900 (-0.2%)   3048 (-1.3%)
This commit is contained in:
Christopher Haster
2024-08-18 15:53:29 -05:00
parent 0e6660d40f
commit fd50596dbc
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lfs.c
+2 -3
View File
@@ -7477,9 +7477,8 @@ static int lfsr_mdir_swap__(lfs_t *lfs, lfsr_mdir_t *mdir_,
// first thing we need to do is read our current revision count
uint32_t rev;
int err = LFSR_BD_READCK(lfs, mdir->rbyd.blocks[0], 0, 0,
&rev, sizeof(uint32_t),
LFSR_CK_PARITY(0, sizeof(uint32_t)));
int err = lfsr_bd_read(lfs, mdir->rbyd.blocks[0], 0, 0,
&rev, sizeof(uint32_t));
if (err && err != LFS_ERR_CORRUPT) {
return err;
}