scripts: Prefer objdump --syms over -t in scripts
objdump --syms is a bit more self-documenting. The other uses of objdump already use the long forms (--dwarf=rawline, --dwarf=info).
This commit is contained in:
+1
-1
@@ -228,7 +228,7 @@ def collect_syms(obj_path, sections=None, global_=False, *,
|
|||||||
|
|
||||||
# find symbol addresses and sizes
|
# find symbol addresses and sizes
|
||||||
syms = []
|
syms = []
|
||||||
cmd = objdump_path + ['-t', obj_path]
|
cmd = objdump_path + ['--syms', obj_path]
|
||||||
if args.get('verbose'):
|
if args.get('verbose'):
|
||||||
print(' '.join(shlex.quote(c) for c in cmd))
|
print(' '.join(shlex.quote(c) for c in cmd))
|
||||||
proc = sp.Popen(cmd,
|
proc = sp.Popen(cmd,
|
||||||
|
|||||||
+1
-1
@@ -237,7 +237,7 @@ def collect_syms(obj_path, sections=None, global_=False, *,
|
|||||||
|
|
||||||
# find symbol addresses and sizes
|
# find symbol addresses and sizes
|
||||||
syms = []
|
syms = []
|
||||||
cmd = objdump_path + ['-t', obj_path]
|
cmd = objdump_path + ['--syms', obj_path]
|
||||||
if args.get('verbose'):
|
if args.get('verbose'):
|
||||||
print(' '.join(shlex.quote(c) for c in cmd))
|
print(' '.join(shlex.quote(c) for c in cmd))
|
||||||
proc = sp.Popen(cmd,
|
proc = sp.Popen(cmd,
|
||||||
|
|||||||
+1
-1
@@ -228,7 +228,7 @@ def collect_syms(obj_path, sections=None, global_=False, *,
|
|||||||
|
|
||||||
# find symbol addresses and sizes
|
# find symbol addresses and sizes
|
||||||
syms = []
|
syms = []
|
||||||
cmd = objdump_path + ['-t', obj_path]
|
cmd = objdump_path + ['--syms', obj_path]
|
||||||
if args.get('verbose'):
|
if args.get('verbose'):
|
||||||
print(' '.join(shlex.quote(c) for c in cmd))
|
print(' '.join(shlex.quote(c) for c in cmd))
|
||||||
proc = sp.Popen(cmd,
|
proc = sp.Popen(cmd,
|
||||||
|
|||||||
+1
-1
@@ -331,7 +331,7 @@ def collect_syms(obj_path, sections=None, global_=False, *,
|
|||||||
|
|
||||||
# find symbol addresses and sizes
|
# find symbol addresses and sizes
|
||||||
syms = []
|
syms = []
|
||||||
cmd = objdump_path + ['-t', obj_path]
|
cmd = objdump_path + ['--syms', obj_path]
|
||||||
if args.get('verbose'):
|
if args.get('verbose'):
|
||||||
print(' '.join(shlex.quote(c) for c in cmd))
|
print(' '.join(shlex.quote(c) for c in cmd))
|
||||||
proc = sp.Popen(cmd,
|
proc = sp.Popen(cmd,
|
||||||
|
|||||||
+1
-1
@@ -237,7 +237,7 @@ def collect_syms(obj_path, sections=None, global_=False, *,
|
|||||||
|
|
||||||
# find symbol addresses and sizes
|
# find symbol addresses and sizes
|
||||||
syms = []
|
syms = []
|
||||||
cmd = objdump_path + ['-t', obj_path]
|
cmd = objdump_path + ['--syms', obj_path]
|
||||||
if args.get('verbose'):
|
if args.get('verbose'):
|
||||||
print(' '.join(shlex.quote(c) for c in cmd))
|
print(' '.join(shlex.quote(c) for c in cmd))
|
||||||
proc = sp.Popen(cmd,
|
proc = sp.Popen(cmd,
|
||||||
|
|||||||
Reference in New Issue
Block a user