From bd7004a4f39a7217ed29bc0c0acb6b35d0fbc602 Mon Sep 17 00:00:00 2001
From: Christopher Haster <geky@geky.net>
Date: Wed, 4 Dec 2024 16:26:54 -0600
Subject: [PATCH] scripts: Prefer objdump --syms over -t in scripts

objdump --syms is a bit more self-documenting.

The other uses of objdump already use the long forms (--dwarf=rawline,
--dwarf=info).
---
 scripts/code.py   | 2 +-
 scripts/ctx.py    | 2 +-
 scripts/data.py   | 2 +-
 scripts/perf.py   | 2 +-
 scripts/perfbd.py | 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/scripts/code.py b/scripts/code.py
index 9db4502f..8d0d69ac 100755
--- a/scripts/code.py
+++ b/scripts/code.py
@@ -228,7 +228,7 @@ def collect_syms(obj_path, sections=None, global_=False, *,
 
     # find symbol addresses and sizes
     syms = []
-    cmd = objdump_path + ['-t', obj_path]
+    cmd = objdump_path + ['--syms', obj_path]
     if args.get('verbose'):
         print(' '.join(shlex.quote(c) for c in cmd))
     proc = sp.Popen(cmd,
diff --git a/scripts/ctx.py b/scripts/ctx.py
index 317ca3b2..6bbc0ea3 100755
--- a/scripts/ctx.py
+++ b/scripts/ctx.py
@@ -237,7 +237,7 @@ def collect_syms(obj_path, sections=None, global_=False, *,
 
     # find symbol addresses and sizes
     syms = []
-    cmd = objdump_path + ['-t', obj_path]
+    cmd = objdump_path + ['--syms', obj_path]
     if args.get('verbose'):
         print(' '.join(shlex.quote(c) for c in cmd))
     proc = sp.Popen(cmd,
diff --git a/scripts/data.py b/scripts/data.py
index 63c636fc..e394ac95 100755
--- a/scripts/data.py
+++ b/scripts/data.py
@@ -228,7 +228,7 @@ def collect_syms(obj_path, sections=None, global_=False, *,
 
     # find symbol addresses and sizes
     syms = []
-    cmd = objdump_path + ['-t', obj_path]
+    cmd = objdump_path + ['--syms', obj_path]
     if args.get('verbose'):
         print(' '.join(shlex.quote(c) for c in cmd))
     proc = sp.Popen(cmd,
diff --git a/scripts/perf.py b/scripts/perf.py
index 4674768d..fe53cdcc 100755
--- a/scripts/perf.py
+++ b/scripts/perf.py
@@ -331,7 +331,7 @@ def collect_syms(obj_path, sections=None, global_=False, *,
 
     # find symbol addresses and sizes
     syms = []
-    cmd = objdump_path + ['-t', obj_path]
+    cmd = objdump_path + ['--syms', obj_path]
     if args.get('verbose'):
         print(' '.join(shlex.quote(c) for c in cmd))
     proc = sp.Popen(cmd,
diff --git a/scripts/perfbd.py b/scripts/perfbd.py
index 51682194..1c659b89 100755
--- a/scripts/perfbd.py
+++ b/scripts/perfbd.py
@@ -237,7 +237,7 @@ def collect_syms(obj_path, sections=None, global_=False, *,
 
     # find symbol addresses and sizes
     syms = []
-    cmd = objdump_path + ['-t', obj_path]
+    cmd = objdump_path + ['--syms', obj_path]
     if args.get('verbose'):
         print(' '.join(shlex.quote(c) for c in cmd))
     proc = sp.Popen(cmd,