From ff4cc52ebb64f812d5f3df9770668a95030631cc Mon Sep 17 00:00:00 2001 From: Christopher Haster Date: Wed, 24 Jul 2024 13:30:09 -0500 Subject: [PATCH] Switched lfsr_fs_ckmeta/ckdata to use lfsr_mtree_traverse These should never need to mutate the filesystem, so calling lfsr_mtree_gc doesn't really make sense. This mainly matters for link-time gc in case we never need lfsr_mtree_gc (readonly mode?). Unfortunately this adds a code cost because the optional pointers to lfsr_mtree_traverse can no longer be const-propagated: code stack before: 36284 2704 after: 36292 (+0.0%) 2704 (+0.0%) --- lfs.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lfs.c b/lfs.c index 3f8aef1a..cf6256d4 100644 --- a/lfs.c +++ b/lfs.c @@ -12995,10 +12995,10 @@ int lfsr_fs_mkconsistent(lfs_t *lfs) { // check the filesystem for metadata errors int lfsr_fs_ckmeta(lfs_t *lfs) { - // we leave this up to lfsr_mtree_gc + // we leave this up to lfsr_mtree_traverse lfsr_traversal_t t = LFSR_TRAVERSAL(LFS_T_CKMETA); while (true) { - int err = lfsr_mtree_gc(lfs, &t, + int err = lfsr_mtree_traverse(lfs, &t, NULL, NULL); if (err) { if (err == LFS_ERR_NOENT) { @@ -13013,10 +13013,10 @@ int lfsr_fs_ckmeta(lfs_t *lfs) { // check the filesystem for metadata + data errors int lfsr_fs_ckdata(lfs_t *lfs) { - // we leave this up to lfsr_mtree_gc + // we leave this up to lfsr_mtree_traverse lfsr_traversal_t t = LFSR_TRAVERSAL(LFS_T_CKMETA | LFS_T_CKDATA); while (true) { - int err = lfsr_mtree_gc(lfs, &t, + int err = lfsr_mtree_traverse(lfs, &t, NULL, NULL); if (err) { if (err == LFS_ERR_NOENT) {