Github/littlefs
1
Fork 0
Code Actions Activity

Made lfsr_bshrub_init a bit safer

Browse Source 
We don't strictly need to initialize all of the shrub fields, but the
path of bnulls -> bshrubs -> btrees in the file logic is complex. It's
highly likely leaving these uninitialized will cause bugs in the future.

This does come with a small code cost, but better safe than sorry:

           code          stack          ctx
  before: 36436           2608          640
  after:  36476 (+0.1%)   2608 (+0.0%)  640 (+0.0%)
This commit is contained in:
Christopher Haster
2025-02-03 03:07:30 -06:00
parent 05937f8ffa
commit fd62ef9674
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lfs.c
+3
View File
@@ -6131,7 +6131,10 @@ static int lfsr_shrub_commit(lfs_t *lfs, lfsr_rbyd_t *rbyd_,
// create a non-existant bshrub // create a non-existant bshrub
static void lfsr_bshrub_init(lfsr_bshrub_t *bshrub) { static void lfsr_bshrub_init(lfsr_bshrub_t *bshrub) {
bshrub->weight = 0; bshrub->weight = 0;
bshrub->blocks[0] = -1;
bshrub->trunk = 0; bshrub->trunk = 0;
// force estimate recalculation
bshrub->eoff = -1;
} }
static inline bool lfsr_bshrub_isbnull(const lfsr_bshrub_t *bshrub) { static inline bool lfsr_bshrub_isbnull(const lfsr_bshrub_t *bshrub) {