scripts: Adopted default visibility in scripts with complex fields
This makes it so scripts with complex fields will still output all fields to output csv/json files, while only showing a user-friendly subset unless -f/--field is explicitly provided. While internal fields are often too much information to show by default, csv/json files are expected to go to other scripts, not humans. So more information is more useful up until you actually hit a performance bottleneck. And if you _do_ somehow manage to hit a performance bottleneck, you can always limit the output with explicit -f/--field flags.
This commit is contained in:
+4
-2
@@ -1088,8 +1088,10 @@ def main(obj_paths, *,
|
||||
else:
|
||||
by = ['struct']
|
||||
|
||||
visible = None
|
||||
if fields is None:
|
||||
fields = ['size', 'align']
|
||||
fields = ['off', 'size', 'align']
|
||||
visible = ['size', 'align']
|
||||
|
||||
# figure out depth
|
||||
if depth is None:
|
||||
@@ -1169,7 +1171,7 @@ def main(obj_paths, *,
|
||||
if not args.get('quiet'):
|
||||
table(StructResult, results, diff_results,
|
||||
by=by,
|
||||
fields=fields,
|
||||
fields=visible if visible is not None else fields,
|
||||
sort=sort,
|
||||
labels=labels,
|
||||
depth=depth,
|
||||
|
||||
Reference in New Issue
Block a user