From d36d67c9b07dc017abaf902ac05753c4983e3d51 Mon Sep 17 00:00:00 2001 From: Christopher Haster Date: Mon, 6 Nov 2023 20:26:26 -0600 Subject: [PATCH] Dropped --github from plotmpl.py - Not as easy to read as --ggplot, the light shades are maybe poorly suited for plots vs other larger block elements on GitHub. I don't know, I'm not really a graphic designer. - GitHub may be a moving target in the future. - GitHub is already a moving target because it has like 9 different optional color schemes (which is good!), so most of the time the colors won't match anyways. - The neutral gray of --ggplot works just as well outside of GitHub. Worst case, --github was just a preset color palette, so it could in theory be emulated with --foreground + --background + --font-color. --- scripts/plotmpl.py | 24 ------------------------ 1 file changed, 24 deletions(-) diff --git a/scripts/plotmpl.py b/scripts/plotmpl.py index 9a89fd2c..19a963a8 100755 --- a/scripts/plotmpl.py +++ b/scripts/plotmpl.py @@ -592,7 +592,6 @@ def main(csv_paths, output, *, dark=False, ggplot=False, xkcd=False, - github=False, font=None, font_size=FONT_SIZE, font_color=None, @@ -608,25 +607,6 @@ def main(csv_paths, output, *, else: svg = True - # some shortcuts for color schemes - if github: - ggplot = True - if font_color is None: - if dark: - font_color = '#e6edf3' - else: - font_color = '#1f2328' - if foreground is None: - if dark: - foreground = '#1f242c' - else: - foreground = '#eaeef2' - if background is None: - if dark: - background = '#0d1117' - else: - background = '#ffffff' - # what colors/alphas/formats to use? if colors is not None: colors_ = colors @@ -1284,10 +1264,6 @@ if __name__ == "__main__": '--xkcd', action='store_true', help="Use the xkcd style.") - parser.add_argument( - '--github', - action='store_true', - help="Use the ggplot style with GitHub colors.") parser.add_argument( '--font', type=lambda x: [x.strip() for x in x.split(',')],