From cda2f6f1da0e8f812bf631c4962181a2d4816532 Mon Sep 17 00:00:00 2001 From: Christopher Haster Date: Wed, 30 Nov 2022 00:14:52 -0600 Subject: [PATCH] Changed test_runner to run with -Pnone,linear by default The linear powerloss heuristic provides very good powerloss coverage without a significant runtime hit, so there's really no reason to run the tests without -Plinear. Previous behavior can be accomplished with an explicit -Pnone. --- .github/workflows/test.yml | 5 ++--- runners/test_runner.c | 7 +++++-- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 697a9b6c..6ebe4a63 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -92,8 +92,7 @@ jobs: - name: test run: | make clean - # TODO include this by default? - TESTFLAGS="$TESTFLAGS -Pnone,linear" make test + make test # collect coverage info # @@ -372,7 +371,7 @@ jobs: # on one geometry - name: test-valgrind run: | - TESTFLAGS="$TESTFLAGS -Gdefault --valgrind" make test + TESTFLAGS="$TESTFLAGS --valgrind -Gdefault -Pnone" make test # test that compilation is warning free under clang # run with Clang, mostly to check for Clang-specific warnings diff --git a/runners/test_runner.c b/runners/test_runner.c index 39237695..0855fc54 100644 --- a/runners/test_runner.c +++ b/runners/test_runner.c @@ -1788,10 +1788,13 @@ const char *const builtin_powerlosses_help[] = { "Run a custom leb16-encoded set of power-losses.", }; +// default to -Pnone,linear, which provides a good heuristic while still +// running quickly const test_powerloss_t *test_powerlosses = (const test_powerloss_t[]){ - {"none", run_powerloss_none, NULL, 0}, + {"none", run_powerloss_none, NULL, 0}, + {"linear", run_powerloss_linear, NULL, 0}, }; -size_t test_powerloss_count = 1; +size_t test_powerloss_count = 2; static void list_powerlosses(void) { // at least size so that names fit