From bd4a5e5ab39b746ddf6d7995c5f600fcd8943c30 Mon Sep 17 00:00:00 2001
From: Christopher Haster <geky@geky.net>
Date: Sun, 12 May 2024 00:00:21 -0500
Subject: [PATCH] Tried to better budget test runtime

The main idea here is that diverse tests are better than many similar
tests.

Sure, if we throw fuzz tests at the system all day we'll eventually find
more bugs, but if a developer is in the loop that time is going to be
better spent writing specific tests targeting the fragile parts of the
system.

And don't worry, we can still throw fuzz tests at the system all day by
specifying explicit seeds with -DSEED=blah.

Changes:

- Limited dir-related powerloss fuzz testing to N <= 16.

  These tests were the biggest culprit of excessive test runtime,
  requiring O(n^2) redundant operations to recover from powerlosses
  (they just replay the full sequence on powerloss).

- As a tradeoff, bumped most fuzz tests to a minimum of 20 seeds.

  The big exception being the test_fwrite tests, which are heavily
  parameterized and already take the most time to run. Each parameter
  combination also multiplies the effective number of seeds, so
  increasing the number of base seeds will probably have diminishing
  returns.

- Limited test_fwrite_reversed to SIZE <= 4*1024*CHUNK.

  Writing a file backwards is just about the worst way you could write a
  file, since all buffering/coalescing expect writes to eventually make
  forward progress. On the flip side, because it's uncommon, writing a
  file backwards is also a great way to find bugs. But at some point a
  compromise needs to be made.

Impacted test runtimes:

  case                                otime    ntime    dtime
  test_btree_push_fuzz                  0.3      0.5     +0.2 (+60.2%)
  test_btree_push_sparse_fuzz           0.4      3.3     +2.9 (+720.4%)
  test_btree_update_fuzz                0.4      0.9     +0.6 (+141.6%)
  test_btree_update_sparse_fuzz         0.5      4.5     +4.1 (+857.4%)
  test_btree_pop_fuzz                   0.6      2.3     +1.7 (+314.7%)
  test_btree_pop_sparse_fuzz            1.2      5.7     +4.4 (+356.2%)
  test_btree_split_fuzz                 0.5      1.4     +0.8 (+150.2%)
  test_btree_split_sparse_fuzz          0.4      5.6     +5.1 (+1163.2%)
  test_btree_find_fuzz                  0.5      0.7     +0.2 (+50.7%)
  test_btree_find_sparse_fuzz           1.0      3.0     +2.0 (+189.8%)
  test_btree_traversal_fuzz             0.6      2.3     +1.6 (+260.4%)
  test_dirs_mkdir_many                  3.3      2.1     -1.3 (-37.8%)
  test_dirs_mkdir_many_backwards        3.5      2.1     -1.4 (-39.9%)
  test_dirs_mkdir_fuzz                115.3    106.4     -8.9 (-7.7%)
  test_dirs_rm_many                   283.9     76.8   -207.0 (-72.9%)
  test_dirs_rm_many_backwards         216.1     80.6   -135.5 (-62.7%)
  test_dirs_rm_fuzz                   647.0     68.5   -578.5 (-89.4%)
  test_dirs_mv_many                    14.2     15.4     +1.1 (+7.9%)
  test_dirs_mv_many_backwards          16.5     14.5     -2.1 (-12.5%)
  test_dirs_mv_fuzz                  1932.5    156.7  -1775.8 (-91.9%)
  test_dirs_general_fuzz              561.9     74.5   -487.4 (-86.7%)
  test_dread_recursive_rm             336.6     46.2   -290.4 (-86.3%)
  test_dread_recursive_mv              55.5     44.6    -11.0 (-19.8%)
  test_fsync_rrrr_fuzz                  0.4      0.3     -0.1 (-18.4%)
  test_fsync_wrrr_fuzz                  8.0     12.4     +4.5 (+56.0%)
  test_fsync_wwww_fuzz                 13.2     33.4    +20.2 (+152.6%)
  test_fsync_wwrr_fuzz                  5.4     50.9    +45.5 (+841.6%)
  test_fsync_rwrw_fuzz                  2.4      8.4     +6.0 (+253.9%)
  test_fsync_rwrw_sparse_fuzz           3.2      7.5     +4.2 (+129.9%)
  test_fsync_rwtfrwtf_sparse_fuzz       6.1      8.5     +2.4 (+39.3%)
  test_fsync_drrr_fuzz                 11.8      9.2     -2.6 (-21.8%)
  test_fsync_wddd_fuzz                  9.3     11.9     +2.6 (+28.0%)
  test_fsync_rwdrwd_fuzz                1.6     33.1    +31.5 (+1963.4%)
  test_fsync_rwdrwd_sparse_fuzz         0.3      1.8     +1.4 (+418.8%)
  test_fsync_rwtfdrwtfd_sparse_fuzz     0.3      1.1     +0.8 (+260.2%)
  test_fwrite_reversed                728.5    345.2   -383.3 (-52.6%)
  TOTAL                              7587.5   3792.3  -3795.2 (-50.0%)
---
 tests/test_btree.toml  | 22 +++++++--------
 tests/test_dirs.toml   | 28 +++++++++----------
 tests/test_dread.toml  |  4 +--
 tests/test_files.toml  |  8 +++---
 tests/test_fsync.toml  | 24 ++++++++--------
 tests/test_fwrite.toml | 62 ++++++++++++++++++++++--------------------
 6 files changed, 75 insertions(+), 73 deletions(-)

diff --git a/tests/test_btree.toml b/tests/test_btree.toml
index 79e72b6d..10cc9a20 100644
--- a/tests/test_btree.toml
+++ b/tests/test_btree.toml
@@ -415,7 +415,7 @@ code = '''
 
 [cases.test_btree_push_fuzz]
 defines.N = [1, 2, 4, 8, 16, 32, 64, 128, 256, 512]
-defines.SEED = 'range(10)'
+defines.SEED = 'range(20)'
 in = 'lfs.c'
 code = '''
     lfs_t lfs;
@@ -576,7 +576,7 @@ code = '''
 [cases.test_btree_push_sparse_fuzz]
 defines.N = [1, 2, 4, 8, 16, 32, 64, 128, 256, 512]
 defines.W = 5
-defines.SEED = 'range(10)'
+defines.SEED = 'range(20)'
 in = 'lfs.c'
 code = '''
     lfs_t lfs;
@@ -971,7 +971,7 @@ code = '''
 [cases.test_btree_update_fuzz]
 defines.N = [1, 2, 4, 8, 16, 32, 64, 128, 256, 512]
 defines.SAMPLES = 10
-defines.SEED = 'range(10)'
+defines.SEED = 'range(20)'
 in = 'lfs.c'
 code = '''
     lfs_t lfs;
@@ -1163,7 +1163,7 @@ code = '''
 [cases.test_btree_update_sparse_fuzz]
 defines.N = [1, 2, 4, 8, 16, 32, 64, 128, 256, 512]
 defines.W = 5
-defines.SEED = 'range(10)'
+defines.SEED = 'range(20)'
 in = 'lfs.c'
 code = '''
     lfs_t lfs;
@@ -1813,7 +1813,7 @@ code = '''
 [cases.test_btree_pop_fuzz]
 defines.N = [1, 2, 4, 8, 16, 32, 64, 128, 256, 512]
 defines.REMAINING = [64, 2, 1, 0]
-defines.SEED = 'range(10)'
+defines.SEED = 'range(20)'
 if = 'N > REMAINING'
 in = 'lfs.c'
 code = '''
@@ -2040,7 +2040,7 @@ code = '''
 defines.N = [1, 2, 4, 8, 16, 32, 64, 128, 256, 512]
 defines.W = 5
 defines.REMAINING = [64, 2, 1, 0]
-defines.SEED = 'range(10)'
+defines.SEED = 'range(20)'
 if = 'N > REMAINING'
 in = 'lfs.c'
 code = '''
@@ -2270,7 +2270,7 @@ code = '''
 
 [cases.test_btree_split_fuzz]
 defines.N = [1, 2, 4, 8, 16, 32, 64, 128, 256, 512]
-defines.SEED = 'range(10)'
+defines.SEED = 'range(20)'
 in = 'lfs.c'
 code = '''
     lfs_t lfs;
@@ -2430,7 +2430,7 @@ code = '''
 [cases.test_btree_split_sparse_fuzz]
 defines.N = [1, 2, 4, 8, 16, 32, 64, 128, 256, 512]
 defines.W = 5
-defines.SEED = 'range(10)'
+defines.SEED = 'range(20)'
 in = 'lfs.c'
 code = '''
     lfs_t lfs;
@@ -3593,7 +3593,7 @@ code = '''
 
 [cases.test_btree_find_fuzz]
 defines.N = [1, 2, 4, 8, 16, 32, 64, 128, 256, 512]
-defines.SEED = 'range(10)'
+defines.SEED = 'range(20)'
 in = 'lfs.c'
 code = '''
     lfs_t lfs;
@@ -3792,7 +3792,7 @@ code = '''
 [cases.test_btree_find_sparse_fuzz]
 defines.N = [1, 2, 4, 8, 16, 32, 64, 128, 256, 512]
 defines.W = 5
-defines.SEED = 'range(10)'
+defines.SEED = 'range(20)'
 in = 'lfs.c'
 code = '''
     lfs_t lfs;
@@ -4481,7 +4481,7 @@ code = '''
 
 [cases.test_btree_traversal_fuzz]
 defines.N = [1, 2, 4, 8, 16, 32, 64, 128, 256, 512]
-defines.SEED = 'range(10)'
+defines.SEED = 'range(20)'
 in = 'lfs.c'
 code = '''
     lfs_t lfs;
diff --git a/tests/test_dirs.toml b/tests/test_dirs.toml
index cf88ec82..8a8d4e1a 100644
--- a/tests/test_dirs.toml
+++ b/tests/test_dirs.toml
@@ -742,7 +742,7 @@ code = '''
 defines.N = [1, 2, 4, 8, 16, 32, 64, 128, 256, 512]
 defines.REMOUNT = [false, true]
 # limit powerloss testing due to time
-if = '!TEST_PLS || N <= 32'
+if = '!TEST_PLS || N <= 16'
 reentrant = true
 code = '''
     // format once per test
@@ -825,7 +825,7 @@ code = '''
 defines.N = [1, 2, 4, 8, 16, 32, 64, 128, 256, 512]
 defines.REMOUNT = [false, true]
 # limit powerloss testing due to time
-if = '!TEST_PLS || N <= 32'
+if = '!TEST_PLS || N <= 16'
 reentrant = true
 code = '''
     // format once per test
@@ -1280,9 +1280,9 @@ code = '''
 defines.N = [1, 2, 4, 8, 16, 32, 64, 128, 256, 512]
 defines.PARENT = [false, true]
 defines.REMOUNT = [false, true]
-defines.SEED = 'range(10)'
+defines.SEED = 'range(20)'
 # limit powerloss testing due to time
-if = '!TEST_PLS || N <= 64'
+if = '!TEST_PLS || N <= 16'
 reentrant = true
 code = '''
     // format once per test
@@ -3283,7 +3283,7 @@ defines.REMOUNT = [false, true]
 if = [
     'N > REMAINING',
     # limit powerloss testing due to time
-    '!TEST_PLS || N <= 32',
+    '!TEST_PLS || N <= 16',
 ]
 reentrant = true
 code = '''
@@ -3406,7 +3406,7 @@ defines.REMOUNT = [false, true]
 if = [
     'N > REMAINING',
     # limit powerloss testing due to time
-    '!TEST_PLS || N <= 32',
+    '!TEST_PLS || N <= 16',
 ]
 reentrant = true
 code = '''
@@ -4203,9 +4203,9 @@ code = '''
 defines.N = [1, 2, 4, 8, 16, 32, 64, 128, 256, 512]
 defines.PARENT = [false, true]
 defines.REMOUNT = [false, true]
-defines.SEED = 'range(10)'
+defines.SEED = 'range(20)'
 # limit powerloss testing due to time
-if = '!TEST_PLS || N <= 64'
+if = '!TEST_PLS || N <= 16'
 reentrant = true
 code = '''
     // format once per test
@@ -5735,7 +5735,7 @@ defines.N = [1, 2, 4, 8, 16, 32, 64, 128, 256, 512]
 defines.BEFORE = [false, true]
 defines.REMOUNT = [false, true]
 # limit powerloss testing due to time
-if = '!TEST_PLS || N <= 32'
+if = '!TEST_PLS || N <= 16'
 reentrant = true
 code = '''
     // format once per test
@@ -5858,7 +5858,7 @@ defines.N = [1, 2, 4, 8, 16, 32, 64, 128, 256, 512]
 defines.BEFORE = [false, true]
 defines.REMOUNT = [false, true]
 # limit powerloss testing due to time
-if = '!TEST_PLS || N <= 32'
+if = '!TEST_PLS || N <= 16'
 reentrant = true
 code = '''
     // format once per test
@@ -6671,9 +6671,9 @@ code = '''
 defines.N = [1, 2, 4, 8, 16, 32, 64, 128, 256, 512]
 defines.PARENT = [false, true]
 defines.REMOUNT = [false, true]
-defines.SEED = 'range(10)'
+defines.SEED = 'range(20)'
 # limit powerloss testing due to time
-if = '!TEST_PLS || N <= 64'
+if = '!TEST_PLS || N <= 16'
 reentrant = true
 code = '''
     // format once per test
@@ -6816,9 +6816,9 @@ code = '''
 defines.N = [1, 2, 4, 8, 16, 32, 64, 128, 256, 512]
 defines.PARENT = [false, true]
 defines.REMOUNT = [false, true]
-defines.SEED = 'range(10)'
+defines.SEED = 'range(20)'
 # limit powerloss testing due to time
-if = '!TEST_PLS || N <= 64'
+if = '!TEST_PLS || N <= 16'
 reentrant = true
 code = '''
     // format once per test
diff --git a/tests/test_dread.toml b/tests/test_dread.toml
index 7eba40ed..d47314bb 100644
--- a/tests/test_dread.toml
+++ b/tests/test_dread.toml
@@ -1496,7 +1496,7 @@ defines.PARENT = [false, true]
 # SEEK=2 => rewind then seek
 defines.SEEK = [0, 1, 2]
 # limit powerloss testing due to time
-if = '!TEST_PLS || N <= 32'
+if = '!TEST_PLS || N <= 16'
 reentrant = true
 code = '''
     // format once per test
@@ -1631,7 +1631,7 @@ defines.PARENT = [0, 1, 2]
 # SEEK=2 => rewind then seek
 defines.SEEK = [0, 1, 2]
 # limit powerloss testing due to time
-if = '!TEST_PLS || N <= 32'
+if = '!TEST_PLS || N <= 16'
 reentrant = true
 code = '''
     // format once per test
diff --git a/tests/test_files.toml b/tests/test_files.toml
index 8593d979..a78bee9c 100644
--- a/tests/test_files.toml
+++ b/tests/test_files.toml
@@ -772,7 +772,7 @@ defines.SIZE = [
     '4*BLOCK_SIZE',
 ]
 defines.REMOUNT = [false, true]
-defines.SEED = 'range(10)'
+defines.SEED = 'range(20)'
 if = '(SIZE*N)/BLOCK_SIZE <= 32'
 code = '''
     lfs_t lfs;
@@ -1122,7 +1122,7 @@ defines.SIZE = [
     '4*BLOCK_SIZE',
 ]
 defines.REMOUNT = [false, true]
-defines.SEED = 'range(10)'
+defines.SEED = 'range(20)'
 if = '(SIZE*N)/BLOCK_SIZE <= 32'
 code = '''
     lfs_t lfs;
@@ -2058,7 +2058,7 @@ defines.SIZE = [
     '4*BLOCK_SIZE',
 ]
 defines.REMOUNT = [false, true]
-defines.SEED = 'range(10)'
+defines.SEED = 'range(20)'
 if = '(SIZE*N)/BLOCK_SIZE <= 32'
 code = '''
     lfs_t lfs;
@@ -2252,7 +2252,7 @@ defines.SIZE = [
     '4*BLOCK_SIZE',
 ]
 defines.REMOUNT = [false, true]
-defines.SEED = 'range(10)'
+defines.SEED = 'range(20)'
 if = '(SIZE*N)/BLOCK_SIZE <= 32'
 code = '''
     lfs_t lfs;
diff --git a/tests/test_fsync.toml b/tests/test_fsync.toml
index 5a3668e6..83fcad29 100644
--- a/tests/test_fsync.toml
+++ b/tests/test_fsync.toml
@@ -534,7 +534,7 @@ code = '''
 
 [cases.test_fsync_rrrr_fuzz]
 defines.R = 4
-defines.SEED = 'range(10)'
+defines.SEED = 'range(20)'
 defines.N = 20
 defines.SIZE = [
     'CACHE_SIZE/2',
@@ -687,7 +687,7 @@ defines.SYNC = [0, 1, 2]
 # FLUSH=1 => flush via lfsr_file_flush
 # FLUSH=2 => flush via LFS_O_FLUSH
 defines.FLUSH = [0, 1, 2]
-defines.SEED = 'range(10)'
+defines.SEED = 'range(20)'
 defines.N = 20
 defines.SIZE = [
     'CACHE_SIZE/2',
@@ -873,7 +873,7 @@ defines.SYNC = [0, 1, 2]
 # FLUSH=1 => flush via lfsr_file_flush
 # FLUSH=2 => flush via LFS_O_FLUSH
 defines.FLUSH = [0, 1, 2]
-defines.SEED = 'range(10)'
+defines.SEED = 'range(20)'
 defines.N = 20
 defines.SIZE = [
     'CACHE_SIZE/2',
@@ -1066,7 +1066,7 @@ defines.SYNC = [0, 1, 2]
 # FLUSH=1 => flush via lfsr_file_flush
 # FLUSH=2 => flush via LFS_O_FLUSH
 defines.FLUSH = [0, 1, 2]
-defines.SEED = 'range(10)'
+defines.SEED = 'range(20)'
 defines.N = 20
 defines.SIZE = [
     'CACHE_SIZE/2',
@@ -1279,7 +1279,7 @@ defines.SYNC = [0, 1, 2]
 # FLUSH=1 => flush via lfsr_file_flush
 # FLUSH=2 => flush via LFS_O_FLUSH
 defines.FLUSH = [0, 1, 2]
-defines.SEED = 'range(10)'
+defines.SEED = 'range(20)'
 defines.N = 20
 defines.SIZE = [
     'CACHE_SIZE/2',
@@ -1391,7 +1391,7 @@ defines.SYNC = [0, 1, 2]
 # FLUSH=1 => flush via lfsr_file_flush
 # FLUSH=2 => flush via LFS_O_FLUSH
 defines.FLUSH = [0, 1, 2]
-defines.SEED = 'range(10)'
+defines.SEED = 'range(20)'
 defines.N = 40
 defines.SIZE = [
     'CACHE_SIZE/2',
@@ -1525,7 +1525,7 @@ defines.SYNC = [0, 1, 2]
 # FLUSH=1 => flush via lfsr_file_flush
 # FLUSH=2 => flush via LFS_O_FLUSH
 defines.FLUSH = [0, 1, 2]
-defines.SEED = 'range(10)'
+defines.SEED = 'range(20)'
 defines.N = 40
 defines.SIZE = [
     'CACHE_SIZE/2',
@@ -2426,7 +2426,7 @@ defines.SYNC = [0, 1, 2]
 # FLUSH=1 => flush via lfsr_file_flush
 # FLUSH=2 => flush via LFS_O_FLUSH
 defines.FLUSH = [0, 1, 2]
-defines.SEED = 'range(10)'
+defines.SEED = 'range(20)'
 defines.N = 20
 defines.SIZE = [
     'CACHE_SIZE/2',
@@ -2619,7 +2619,7 @@ defines.SYNC = [0, 1, 2]
 # FLUSH=1 => flush via lfsr_file_flush
 # FLUSH=2 => flush via LFS_O_FLUSH
 defines.FLUSH = [0, 1, 2]
-defines.SEED = 'range(10)'
+defines.SEED = 'range(20)'
 defines.N = 20
 defines.SIZE = [
     'CACHE_SIZE/2',
@@ -2827,7 +2827,7 @@ defines.SYNC = [0, 1, 2]
 # FLUSH=1 => flush via lfsr_file_flush
 # FLUSH=2 => flush via LFS_O_FLUSH
 defines.FLUSH = [0, 1, 2]
-defines.SEED = 'range(10)'
+defines.SEED = 'range(20)'
 defines.N = 20
 defines.SIZE = [
     'CACHE_SIZE/2',
@@ -2944,7 +2944,7 @@ defines.RW = 4
 # FLUSH=1 => flush via lfsr_file_flush
 # FLUSH=2 => flush via LFS_O_FLUSH
 defines.FLUSH = [0, 1, 2]
-defines.SEED = 'range(10)'
+defines.SEED = 'range(20)'
 defines.N = 40
 defines.SIZE = [
     'CACHE_SIZE/2',
@@ -3093,7 +3093,7 @@ defines.RW = 4
 # FLUSH=1 => flush via lfsr_file_flush
 # FLUSH=2 => flush via LFS_O_FLUSH
 defines.FLUSH = [0, 1, 2]
-defines.SEED = 'range(10)'
+defines.SEED = 'range(20)'
 defines.N = 40
 defines.SIZE = [
     'CACHE_SIZE/2',
diff --git a/tests/test_fwrite.toml b/tests/test_fwrite.toml
index 3fcf06d0..bb26d1e6 100644
--- a/tests/test_fwrite.toml
+++ b/tests/test_fwrite.toml
@@ -29,8 +29,8 @@ defines.SYNC = [false, true]
 defines.REMOUNT = [false, true]
 if = [
     'CHUNK <= SIZE',
-    # this just save testing time
-    'SIZE / FRAGMENT_SIZE <= 4096',
+    # this just saves testing time
+    'SIZE <= 4*1024*FRAGMENT_SIZE',
 ]
 code = '''
     lfs_t lfs;
@@ -135,8 +135,8 @@ defines.SYNC = [false, true]
 defines.REMOUNT = [false, true]
 if = [
     'CHUNK <= SIZE',
-    # this just save testing time
-    'SIZE / FRAGMENT_SIZE <= 4096',
+    # this just saves testing time
+    'SIZE <= 4*1024*FRAGMENT_SIZE',
 ]
 code = '''
     lfs_t lfs;
@@ -313,8 +313,8 @@ defines.SYNC = [false, true]
 defines.REMOUNT = [false, true]
 if = [
     'CHUNK <= SIZE',
-    # this just save testing time
-    'SIZE / FRAGMENT_SIZE <= 4096',
+    # this just saves testing time
+    'SIZE <= 4*1024*FRAGMENT_SIZE',
 ]
 code = '''
     lfs_t lfs;
@@ -495,7 +495,7 @@ defines.TO = [
 defines.SYNC = [false, true]
 defines.REMOUNT = [false, true]
 if = [
-    # these just save testing time
+    # this just saves testing time
     'FROM / FRAGMENT_SIZE <= 4096',
     'TO / FRAGMENT_SIZE <= 4096',
 ]
@@ -617,7 +617,7 @@ defines.TO = [
 defines.SYNC = [false, true]
 defines.REMOUNT = [false, true]
 if = [
-    # these just save testing time
+    # this just saves testing time
     'FROM / FRAGMENT_SIZE <= 4096',
     'AND / FRAGMENT_SIZE <= 4096',
     'TO / FRAGMENT_SIZE <= 4096',
@@ -749,7 +749,7 @@ defines.TO = [
 defines.SYNC = [false, true]
 defines.REMOUNT = [false, true]
 if = [
-    # these just save testing time
+    # this just saves testing time
     'FROM / FRAGMENT_SIZE <= 4096',
     'TO / FRAGMENT_SIZE <= 4096',
 ]
@@ -875,7 +875,7 @@ defines.TO = [
 defines.SYNC = [false, true]
 defines.REMOUNT = [false, true]
 if = [
-    # these just save testing time
+    # this just saves testing time
     'FROM / FRAGMENT_SIZE <= 4096',
     'AND / FRAGMENT_SIZE <= 4096',
     'TO / FRAGMENT_SIZE <= 4096',
@@ -1011,8 +1011,10 @@ defines.SYNC = [false, true]
 defines.REMOUNT = [false, true]
 if = [
     'CHUNK <= SIZE',
-    # this just save testing time
-    'SIZE / FRAGMENT_SIZE <= 4096',
+    # this just saves testing time
+    'SIZE <= 4*1024*FRAGMENT_SIZE',
+    # writing backwards is expected to be a bit slow
+    'SIZE <= 4*1024*CHUNK',
 ]
 code = '''
     lfs_t lfs;
@@ -1147,8 +1149,8 @@ defines.SYNC = [false, true]
 defines.REMOUNT = [false, true]
 if = [
     'CHUNK <= SIZE',
-    # this just save testing time
-    'SIZE / FRAGMENT_SIZE <= 4096',
+    # this just saves testing time
+    'SIZE <= 4*1024*FRAGMENT_SIZE',
 ]
 code = '''
     lfs_t lfs;
@@ -1334,8 +1336,8 @@ defines.SYNC = [false, true]
 defines.REMOUNT = [false, true]
 if = [
     'CHUNK <= SIZE',
-    # this just save testing time
-    'SIZE / FRAGMENT_SIZE <= 4096',
+    # this just saves testing time
+    'SIZE <= 4*1024*FRAGMENT_SIZE',
 ]
 code = '''
     lfs_t lfs;
@@ -1520,8 +1522,8 @@ defines.SYNC = [false, true]
 defines.REMOUNT = [false, true]
 if = [
     'CHUNK <= SIZE',
-    # this just save testing time
-    'SIZE / FRAGMENT_SIZE <= 4096',
+    # this just saves testing time
+    'SIZE <= 4*1024*FRAGMENT_SIZE',
 ]
 code = '''
     lfs_t lfs;
@@ -1661,8 +1663,8 @@ defines.SYNC = [false, true]
 defines.REMOUNT = [false, true]
 if = [
     'CHUNK <= SIZE',
-    # this just save testing time
-    'SIZE / FRAGMENT_SIZE <= 4096',
+    # this just saves testing time
+    'SIZE <= 4*1024*FRAGMENT_SIZE',
 ]
 code = '''
     lfs_t lfs;
@@ -1804,8 +1806,8 @@ defines.SIZE = [
 defines.CHUNK = [32, 8]
 if = [
     'CHUNK <= SIZE',
-    # this just save testing time
-    'SIZE / FRAGMENT_SIZE <= 4096',
+    # this just saves testing time
+    'SIZE <= 4*1024*FRAGMENT_SIZE',
 ]
 code = '''
     lfs_t lfs;
@@ -1887,8 +1889,8 @@ defines.INIT = [0, 1, 2]
 defines.SYNC = [false, true]
 if = [
     'CHUNK <= SIZE',
-    # this just save testing time
-    'SIZE / FRAGMENT_SIZE <= 4096',
+    # this just saves testing time
+    'SIZE <= 4*1024*FRAGMENT_SIZE',
 ]
 code = '''
     lfs_t lfs;
@@ -2027,8 +2029,8 @@ defines.INIT = [0, 1, 2]
 defines.SYNC = [false, true]
 if = [
     'CHUNK <= SIZE',
-    # this just save testing time
-    'SIZE / FRAGMENT_SIZE <= 4096',
+    # this just saves testing time
+    'SIZE <= 4*1024*FRAGMENT_SIZE',
 ]
 code = '''
     lfs_t lfs;
@@ -2186,8 +2188,8 @@ defines.SIZE = [
 defines.INIT = [0, 1, 2]
 defines.MODE = ['LFS_O_RDONLY', 'LFS_O_WRONLY', 'LFS_O_RDWR']
 if = [
-    # this just save testing time
-    'SIZE / FRAGMENT_SIZE <= 4096',
+    # this just saves testing time
+    'SIZE <= 4*1024*FRAGMENT_SIZE',
 ]
 code = '''
     lfs_t lfs;
@@ -2291,8 +2293,8 @@ defines.SYNC = [false, true]
 defines.REMOUNT = [false, true]
 if = [
     'CHUNK <= SIZE',
-    # this just save testing time
-    'SIZE / FRAGMENT_SIZE <= 4096',
+    # this just saves testing time
+    'SIZE <= 4*1024*FRAGMENT_SIZE',
 ]
 code = '''
     lfs_t lfs;