From bb4d1c517d618a6e59f9e9e098b83d89f8d5ef9d Mon Sep 17 00:00:00 2001 From: Christopher Haster Date: Tue, 11 Feb 2025 03:24:22 -0600 Subject: [PATCH] Fixed missing return err in lfsr_formatinited No idea how long this return has been missing, but we should never ignore a returned err without at least an assert. And this one should definitely not be an assert. Code changes minimal: code stack ctx before: 35552 2440 636 after: 35556 (+0.0%) 2440 (+0.0%) 636 (+0.0%) --- lfs.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lfs.c b/lfs.c index be35d79a..6d7d71bc 100644 --- a/lfs.c +++ b/lfs.c @@ -13828,6 +13828,9 @@ static int lfsr_formatinited(lfs_t *lfs) { uint32_t cksum = rbyd.cksum; err = lfsr_rbyd_appendrattr_(lfs, &rbyd, LFSR_RATTR_LE32( LFSR_TAG_GCKSUMDELTA, 0, lfs_crc32c_cube(cksum))); + if (err) { + return err; + } // and commit err = lfsr_rbyd_appendcksum_(lfs, &rbyd, cksum);