From 9b4e1b4cb7151ccb8c08e3f58142154efeb801d3 Mon Sep 17 00:00:00 2001 From: Christopher Haster Date: Sat, 23 Mar 2024 16:27:19 -0500 Subject: [PATCH] Replace assert(!err) with assert(err == 0) in tests This plays better with prettyasserts.py, which prints the err value on failure. We _could_ extend prettyasserts.py to print the contents of !err patterns, but this risks making the error message more confusing when the target is an actual boolean expression. Keep in mind prettyasserts.py is purely syntactical and doesn't really know the expression's type. --- tests/test_rbyd.toml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/test_rbyd.toml b/tests/test_rbyd.toml index 43baf312..cf8975f4 100644 --- a/tests/test_rbyd.toml +++ b/tests/test_rbyd.toml @@ -3169,7 +3169,7 @@ code = ''' if (j == N-1) { assert(err == LFS_ERR_NOENT); } else { - assert(!err); + assert(err == 0); assert(tag_ == LFSR_TAG_UATTR(j+1+1)); assert(rid_ == -1); assert(lfsr_data_size(data_) == 4); @@ -4094,7 +4094,7 @@ code = ''' int err = lfsr_rbyd_lookup(&lfs, &rbyd, -1, LFSR_TAG_UATTR(attr), &data); if (sim[attr]) { - assert(!err); + assert(err == 0); lfs_ssize_t size = lfsr_data_read(&lfs, &data, buffer, 4); assert(size == 1); assert(memcmp(&sim[attr], buffer, 1) == 0); @@ -6250,12 +6250,12 @@ code = ''' if (u == M-1 && k == N-1) { assert(err == LFS_ERR_NOENT); } else if (u == M-1) { - assert(!err); + assert(err == 0); assert(tag_ == LFSR_TAG_REG); assert(rid_ == k+1); assert(lfsr_data_size(data_) == 4); } else { - assert(!err); + assert(err == 0); assert(tag_ == LFSR_TAG_UATTR(u+1+1)); assert(rid_ == k); assert(lfsr_data_size(data_) == 2);