Github/littlefs
1
Fork 0
Code Actions Activity

emubd/kiwibd: Fixed unused path param, dropped disk_path

Browse Source 
For some reason emubd had both a path argument to lfs3_emubd_create, and
a disk_path config option, with only the disk_path actually being used.

But the real curiosity is why did GCC only starting warning about it
when copied to kiwibd? path is clearly unused in lfs3_emubd_createcfg,
but no warning...

---

Anyways, not sure which one is a better API, but we definitely don't
need two APIs, so eeny meeny miny moe...

Went ahead and chose the lfs3_emubd_create path param for some
consistency with filebd.
This commit is contained in:
Christopher Haster
2025-10-04 17:07:58 -05:00
parent e622656538
commit 982394305e
6 changed files with 114 additions and 98 deletions
Download Patch File Download Diff File Expand all files Collapse all files
runners/test_runner.c
-5
View File
@@ -1319,7 +1319,6 @@ static void run_powerloss_none(
};
struct lfs3_emubd_cfg bdcfg = {
.disk_path = test_disk_path,
.read_sleep = test_read_sleep,
.prog_sleep = test_prog_sleep,
.erase_sleep = test_erase_sleep,
@@ -1380,7 +1379,6 @@ static void run_powerloss_linear(
};
struct lfs3_emubd_cfg bdcfg = {
.disk_path = test_disk_path,
.read_sleep = test_read_sleep,
.prog_sleep = test_prog_sleep,
.erase_sleep = test_erase_sleep,
@@ -1457,7 +1455,6 @@ static void run_powerloss_log(
};
struct lfs3_emubd_cfg bdcfg = {
.disk_path = test_disk_path,
.read_sleep = test_read_sleep,
.prog_sleep = test_prog_sleep,
.erase_sleep = test_erase_sleep,
@@ -1534,7 +1531,6 @@ static void run_powerloss_cycles(
};
struct lfs3_emubd_cfg bdcfg = {
.disk_path = test_disk_path,
.read_sleep = test_read_sleep,
.prog_sleep = test_prog_sleep,
.erase_sleep = test_erase_sleep,
@@ -1709,7 +1705,6 @@ static void run_powerloss_exhaustive(
};
struct lfs3_emubd_cfg bdcfg = {
.disk_path = test_disk_path,
.read_sleep = test_read_sleep,
.prog_sleep = test_prog_sleep,
.erase_sleep = test_erase_sleep,