Github/littlefs
1
Fork 0
Code Actions Activity

Renamed LFS3_T_COMPACTMETA -> LFS3_T_COMPACT (and gc_compact_thresh)

Browse Source 
This effectively reverts 1f824a0:

- LFS3_T_COMPACTMETA -> LFS3_T_COMPACT
- gc_compactmeta_thresh -> gc_compact_thresh

And friends.

After using LFS3_T_COMPACTMETA for a bit, I think it just adds noise
without much value. Especially when next to LFS3_T_LOOKAHEAD,
LFS3_GC_PREERASE, LFS3_M_SYNC, etc.

It's interesting that we already have some very distinct verbs for this
sort of thing based on data type (compact => metadata, garbage-collect
=> disk, compress => data).
This commit is contained in:
Christopher Haster
2025-12-05 01:05:35 -06:00
parent 347c7b7290
commit 7a57b1e2bd
10 changed files with 362 additions and 368 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lfs3.h
+8 -14
View File
@@ -209,8 +209,7 @@ enum lfs3_type {
0x00001000 // Repopulate lookahead/gbmap
#endif
#ifndef LFS3_RDONLY
#define LFS3_F_COMPACTMETA \
0x00008000 // Compact metadata logs
#define LFS3_F_COMPACT 0x00008000 // Compact metadata logs
#endif
#ifndef LFS3_RDONLY
#define LFS3_F_CKMETA 0x00010000 // Check metadata checksums
@@ -257,8 +256,7 @@ enum lfs3_type {
0x00001000 // Repopulate lookahead/gbmap
#endif
#ifndef LFS3_RDONLY
#define LFS3_M_COMPACTMETA \
0x00008000 // Compact metadata logs
#define LFS3_M_COMPACT 0x00008000 // Compact metadata logs
#endif
#define LFS3_M_CKMETA 0x00010000 // Check metadata checksums
#define LFS3_M_CKDATA 0x00020000 // Check metadata + data checksums
@@ -300,8 +298,7 @@ enum lfs3_type {
0x00001000 // Lookahead/gbmap is not full
#endif
#ifndef LFS3_RDONLY
#define LFS3_I_COMPACTMETA \
0x00008000 // Filesystem may have uncompacted metadata
#define LFS3_I_COMPACT 0x00008000 // Filesystem may have uncompacted metadata
#endif
#define LFS3_I_CKMETA 0x00010000 // Metadata checksums not checked recently
#define LFS3_I_CKDATA 0x00020000 // Data checksums not checked recently
@@ -331,8 +328,7 @@ enum lfs3_btype {
0x00001000 // Repopulate lookahead/gbmap
#endif
#ifndef LFS3_RDONLY
#define LFS3_T_COMPACTMETA \
0x00008000 // Compact metadata logs
#define LFS3_T_COMPACT 0x00008000 // Compact metadata logs
#endif
#define LFS3_T_CKMETA 0x00010000 // Check metadata checksums
#define LFS3_T_CKDATA 0x00020000 // Check metadata + data checksums
@@ -356,8 +352,7 @@ enum lfs3_btype {
0x00001000 // Repopulate lookahead/gbmap
#endif
#ifndef LFS3_RDONLY
#define LFS3_CK_COMPACTMETA \
0x00008000 // Compact metadata logs
#define LFS3_CK_COMPACT 0x00008000 // Compact metadata logs
#endif
#define LFS3_CK_CKMETA 0x00010000 // Check metadata checksums
#define LFS3_CK_CKDATA 0x00020000 // Check metadata + data checksums
@@ -372,8 +367,7 @@ enum lfs3_btype {
0x00001000 // Repopulate lookahead/gbmap
#endif
#ifndef LFS3_RDONLY
#define LFS3_GC_COMPACTMETA \
0x00008000 // Compact metadata logs
#define LFS3_GC_COMPACT 0x00008000 // Compact metadata logs
#endif
#define LFS3_GC_CKMETA 0x00010000 // Check metadata checksums
#define LFS3_GC_CKDATA 0x00020000 // Check metadata + data checksums
@@ -382,7 +376,7 @@ enum lfs3_btype {
#define LFS3_GC_ALL ( \
LFS3_IFDEF_RDONLY(0, LFS3_GC_MKCONSISTENT) \
| LFS3_IFDEF_RDONLY(0, LFS3_GC_LOOKAHEAD) \
| LFS3_IFDEF_RDONLY(0, LFS3_GC_COMPACTMETA) \
| LFS3_IFDEF_RDONLY(0, LFS3_GC_COMPACT) \
| LFS3_GC_CKMETA \
| LFS3_GC_CKDATA)
@@ -544,7 +538,7 @@ struct lfs3_cfg {
//
// Set to -1 to disable metadata compaction during gc.
#ifndef LFS3_RDONLY
lfs3_size_t gc_compactmeta_thresh;
lfs3_size_t gc_compact_thresh;
#endif
// Optional statically allocated rcache buffer. Must be rcache_size. By