Github/littlefs
1
Fork 0
Code Actions Activity

Changed lfsr_bd_set to hijack the rcache

Browse Source 
This is a compromise between using a small hardcoded buffer and
cache-access during progs. Instead of getting direct access to the
pcache during progs, we just hijack the rcache, forcefully evicting any
contents it might have.

This gets us cache-access (of at least some cache) without needing to
rewrite lfsr_bd_prog.

The downside is this may result in more rcache misses. Though the use of
lfsr_bd_set is fairly niche in littlefs, so hopefully this doesn't
become a problem.

Code changes:

           code          stack
  before: 33796           2880
  after:  33792 (-0.0%)   2872 (-0.3%)
This commit is contained in:
Christopher Haster
2024-02-20 01:22:16 -06:00
parent 50712a595a
commit 6ede8afffe
1 changed files with 5 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lfs.c
+5 -7
View File
@@ -528,15 +528,13 @@ static int lfsr_bd_cpy(lfs_t *lfs,
static int lfsr_bd_set(lfs_t *lfs, lfs_block_t block, lfs_size_t off, static int lfsr_bd_set(lfs_t *lfs, lfs_block_t block, lfs_size_t off,
uint8_t c, lfs_size_t size, uint8_t c, lfs_size_t size,
uint32_t *cksum_, uint32_t *flcksum_) { uint32_t *cksum_, uint32_t *flcksum_) {
// just use a small hardcoded buffer // hijack the rcache
// lfsr_cache_drop(&lfs->rcache);
// this function is quite a bit more niche than the read-related utils memset(lfs->rcache.buffer, c, lfs_min(size, lfs->cfg->cache_size));
uint8_t buf[4];
memset(buf, c, sizeof(buf));
while (size > 0) { while (size > 0) {
lfs_size_t d = lfs_min(size, sizeof(buf)); lfs_size_t d = lfs_min(size, lfs->cfg->cache_size);
int err = lfsr_bd_prog(lfs, block, off, buf, d, int err = lfsr_bd_prog(lfs, block, off, lfs->rcache.buffer, d,
cksum_, flcksum_); cksum_, flcksum_);
if (err) { if (err) {
return err; return err;