From 5e8344a1c68d40887a4412fba3c1f68b9148136b Mon Sep 17 00:00:00 2001 From: Christopher Haster Date: Sat, 15 Mar 2025 01:46:30 -0500 Subject: [PATCH] scripts: Renamed report -> main_ in perf.py/perfbd.py This is a useful convention. It indicates these functions don't do anything a main function wouldn't normally do. --- scripts/perf.py | 4 ++-- scripts/perfbd.py | 4 ++-- scripts/plot.py | 1 - 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/scripts/perf.py b/scripts/perf.py index 683f7c5f..feab8fc3 100755 --- a/scripts/perf.py +++ b/scripts/perf.py @@ -1481,7 +1481,7 @@ def annotate(Result, results, *, print(line) -def report(perf_paths, *, +def main_(perf_paths, *, by=None, fields=None, defines=[], @@ -1622,7 +1622,7 @@ def main(**args): if args.get('record'): return record(**args) else: - return report(**args) + return main_(**args) if __name__ == "__main__": diff --git a/scripts/perfbd.py b/scripts/perfbd.py index d9590f39..caa31686 100755 --- a/scripts/perfbd.py +++ b/scripts/perfbd.py @@ -1469,7 +1469,7 @@ def annotate(Result, results, *, print(line) -def report(paths, *, +def main_(paths, *, by=None, fields=None, defines=[], @@ -1618,7 +1618,7 @@ def main(**args): if args.get('record'): return record(**args) else: - return report(**args) + return main_(**args) if __name__ == "__main__": diff --git a/scripts/plot.py b/scripts/plot.py index f3e90dc9..fabef971 100755 --- a/scripts/plot.py +++ b/scripts/plot.py @@ -1070,7 +1070,6 @@ class Grid: return grid -# TODO adopt main_ in all result scripts? (vs report) # TODO adopt this keep_open pattern in all ascii-art scripts? def main_(f, csv_paths, *, by=None,