From 5541ad0c004fd9664c6d47f250fe3c8ccbdfc038 Mon Sep 17 00:00:00 2001 From: Christopher Haster Date: Fri, 11 Aug 2023 14:02:37 -0500 Subject: [PATCH] Fixed missed opportunity for wide tags in btree set This code was written before we had wide tags, which were introduced for this exact, and common, use case of needing to replace a range of tag subtypes. Must have just been missed. --- lfs.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/lfs.c b/lfs.c index e69b2bee..a869e88f 100644 --- a/lfs.c +++ b/lfs.c @@ -4531,10 +4531,7 @@ static int lfsr_btree_set(lfs_t *lfs, lfsr_btree_t *btree, // of the rest int degenerate = lfsr_btree_commit(lfs, btree, bid, 1, &rbyd, LFSR_ATTRS( - (tag != rtag - ? LFSR_ATTR(rid, TAG(lfsr_tag_setrm(rtag)), 0, NULL) - : LFSR_ATTR_NOOP), - LFSR_ATTR(rid, TAG(tag), 0, DATA(data)), + LFSR_ATTR(rid, WIDE(TAG(tag)), 0, DATA(data)), LFSR_ATTR(rid, GROW(RM), +weight-rweight, NULL))); if (degenerate < 0) { return degenerate;