Github/littlefs
1
Fork 0
Code Actions Activity

Changed unwritable superblock to ENOSPC for consistency

Browse Source 
While ECORRUPT is not a wrong error code, it doesn't match other
instances of hitting a corrupt block during write. During writes, if
blocks are detected as corrupt their data is evicted and moved to a new
clean block. This means that at the end of a disk's lifetime, exhaustion
errors will be reported as ENOSPC when littlefs can't find any new block
to store the data.

This has the benefit of matching behaviour when a new file is written
and no more blocks can be found, due to either a small disk or corrupted
blocks on disk. To littlefs it's like the disk shrinks in size over
time.
This commit is contained in:
Christopher Haster
2018-08-13 14:20:40 -05:00
parent a2532a34cd
commit 4db96d4d44
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lfs.c
+1 -1
View File
@@ -1237,7 +1237,7 @@ relocate:
// can't relocate superblock, filesystem is now frozen // can't relocate superblock, filesystem is now frozen
if (lfs_pair_cmp(oldpair, (const lfs_block_t[2]){0, 1}) == 0) { if (lfs_pair_cmp(oldpair, (const lfs_block_t[2]){0, 1}) == 0) {
LFS_WARN("Superblock %"PRIu32" has become unwritable", oldpair[1]); LFS_WARN("Superblock %"PRIu32" has become unwritable", oldpair[1]);
return LFS_ERR_CORRUPT; return LFS_ERR_NOSPC;
} }
// relocate half of pair // relocate half of pair
tests/test_format.sh
+1 -1
View File
@@ -22,7 +22,7 @@ echo "--- Invalid superblocks ---"
ln -f -s /dev/zero blocks/0 ln -f -s /dev/zero blocks/0
ln -f -s /dev/zero blocks/1 ln -f -s /dev/zero blocks/1
tests/test.py << TEST tests/test.py << TEST
lfs_format(&lfs, &cfg) => LFS_ERR_CORRUPT; lfs_format(&lfs, &cfg) => LFS_ERR_NOSPC;
TEST TEST
rm blocks/0 blocks/1 rm blocks/0 blocks/1