Github/littlefs
1
Fork 0
Code Actions Activity

Added shortcut encoding for linear/log powerlosses in test-runner

Browse Source 
The previous encoding was a bit problematic with our linear and log
heuristics, which can grow thousands of powerlosses deep. You know you
have a problem when you're copying a test id that spans a dozen lines.

It also meant we were spending O(n^2) time just encoding powerloss ids:

  before: 942.68s
  after:  921.94s (-2.2%)

This new encoding takes advantage of the unused characters in our leb16
encoding, with an 'x' prefix indicating linear-heuristic powerlosses
and a 'y' prefix indicating log-heuristic powerlosses ('w' is used for
negative leb16s).

Before:

  - explicit: 42q2q2
  - linear:   123456789abcdefg1h1i1j1k1l1m1n1o1p1q1r1s1t1u1v1
  - log:      1248g1g2g4g8gg1gg2gg4gg8

After:

  - explicit: 42q2q2
  - linear:   xg2
  - log:      yc
This commit is contained in:
Christopher Haster
2023-11-29 17:59:37 -06:00
parent d485795336
commit 4da7c88eb0
3 changed files with 185 additions and 178 deletions
Download Patch File Download Diff File Expand all files Collapse all files
runners/bench_runner.c
+9 -17
View File
@@ -795,16 +795,15 @@ void bench_seen_cleanup(bench_seen_t *seen) {
static void case_forperm(
const struct bench_suite *suite,
const struct bench_case *case_,
const bench_define_t *defines,
size_t define_count,
const bench_id_t *id,
void (*cb)(
void *data,
const struct bench_suite *suite,
const struct bench_case *case_),
void *data) {
// explicit permutation?
if (defines) {
bench_define_explicit(defines, define_count);
if (id && id->defines) {
bench_define_explicit(id->defines, id->define_count);
size_t permutations = bench_define_permutationpermutations();
for (size_t p = 0; p < permutations; p++) {
@@ -861,7 +860,6 @@ void perm_count(
const struct bench_case *case_) {
struct perm_count_state *state = data;
(void)suite;
(void)case_;
state->total += 1;
@@ -900,8 +898,7 @@ static void summary(void) {
case_forperm(
bench_suites[i],
&bench_suites[i]->cases[j],
bench_ids[t].defines,
bench_ids[t].define_count,
&bench_ids[t],
perm_count,
&perms);
}
@@ -959,8 +956,7 @@ static void list_suites(void) {
case_forperm(
bench_suites[i],
&bench_suites[i]->cases[j],
bench_ids[t].defines,
bench_ids[t].define_count,
&bench_ids[t],
perm_count,
&perms);
}
@@ -1018,8 +1014,7 @@ static void list_cases(void) {
case_forperm(
bench_suites[i],
&bench_suites[i]->cases[j],
bench_ids[t].defines,
bench_ids[t].define_count,
&bench_ids[t],
perm_count,
&perms);
@@ -1224,8 +1219,7 @@ static void list_defines(void) {
case_forperm(
bench_suites[i],
&bench_suites[i]->cases[j],
bench_ids[t].defines,
bench_ids[t].define_count,
&bench_ids[t],
perm_list_defines,
&defines);
}
@@ -1270,8 +1264,7 @@ static void list_permutation_defines(void) {
case_forperm(
bench_suites[i],
&bench_suites[i]->cases[j],
bench_ids[t].defines,
bench_ids[t].define_count,
&bench_ids[t],
perm_list_permutation_defines,
&defines);
}
@@ -1420,8 +1413,7 @@ static void run(void) {
case_forperm(
bench_suites[i],
&bench_suites[i]->cases[j],
bench_ids[t].defines,
bench_ids[t].define_count,
&bench_ids[t],
perm_run,
NULL);
}