From 30175de38414afd6e6e0c77de06649933e535526 Mon Sep 17 00:00:00 2001 From: Christopher Haster Date: Wed, 7 Sep 2022 12:38:04 -0500 Subject: [PATCH] Remove -Wshadow -Wjump-misses-init -Wundef Doing this now specifically because clang does not have -Wjump-misses-init, but I've been looking for an excuse to remove these for a while. These warning flags create more annoyance than they add value. There is probably a reason they aren't included in -Wall + -Wextra. -Wshadow specifically is potentially harmful as it forces coming up with new, sometimes less descriptive names for repeated variables. Dependent projects should use different flags for their dependencies if this introduces problems. --- Makefile | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 7cc59f8a..13879336 100644 --- a/Makefile +++ b/Makefile @@ -41,8 +41,7 @@ override CFLAGS += -DLFS_YES_TRACE endif override CFLAGS += -g3 override CFLAGS += -I. -override CFLAGS += -std=c99 -Wall -pedantic -override CFLAGS += -Wextra -Wshadow -Wjump-misses-init -Wundef +override CFLAGS += -std=c99 -Wall -Wextra -pedantic ifdef VERBOSE override TESTFLAGS += -v