Github/littlefs
1
Fork 0
Code Actions Activity

gha: Merge artifacts on download

Browse Source 
Turns out major versions break things.

Old behavior: Artifacts with same name are merged
New behavior: Artifacts with same name error

Using a pattern and merging on download should fix this at least on the
job-side. Though I do wonder if we'll start running into artifact limit
issues with the new way artifacts are handled...
This commit is contained in:
Christopher Haster
2024-09-19 12:36:20 -05:00
parent 72a4b57f4e
commit 2c4b262c35
3 changed files with 21 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/workflows/release.yml
+9 -6
View File
@@ -30,26 +30,29 @@ jobs:
fetch-depth: 0 fetch-depth: 0
# try to get results from tests # try to get results from tests
- uses: dawidd6/action-download-artifact@v2 - uses: dawidd6/action-download-artifact@v6
continue-on-error: true continue-on-error: true
with: with:
workflow: ${{github.event.workflow_run.name}} workflow: ${{github.event.workflow_run.name}}
run_id: ${{github.event.workflow_run.id}} run_id: ${{github.event.workflow_run.id}}
name: sizes pattern: '{sizes,sizes-*}'
merge-multiple: true
path: sizes path: sizes
- uses: dawidd6/action-download-artifact@v2 - uses: dawidd6/action-download-artifact@v6
continue-on-error: true continue-on-error: true
with: with:
workflow: ${{github.event.workflow_run.name}} workflow: ${{github.event.workflow_run.name}}
run_id: ${{github.event.workflow_run.id}} run_id: ${{github.event.workflow_run.id}}
name: cov pattern: '{cov,cov-*}'
merge-multiple: true
path: cov path: cov
- uses: dawidd6/action-download-artifact@v2 - uses: dawidd6/action-download-artifact@v6
continue-on-error: true continue-on-error: true
with: with:
workflow: ${{github.event.workflow_run.name}} workflow: ${{github.event.workflow_run.name}}
run_id: ${{github.event.workflow_run.id}} run_id: ${{github.event.workflow_run.id}}
name: bench pattern: '{bench,bench-*}'
merge-multiple: true
path: bench path: bench
- name: find-version - name: find-version
.github/workflows/status.yml
+6 -4
View File
@@ -13,12 +13,13 @@ jobs:
status: status:
runs-on: ubuntu-latest runs-on: ubuntu-latest
steps: steps:
- uses: dawidd6/action-download-artifact@v2 - uses: dawidd6/action-download-artifact@v6
continue-on-error: true continue-on-error: true
with: with:
workflow: ${{github.event.workflow_run.name}} workflow: ${{github.event.workflow_run.name}}
run_id: ${{github.event.workflow_run.id}} run_id: ${{github.event.workflow_run.id}}
name: status pattern: '{status,status-*}'
merge-multiple: true
path: status path: status
- name: update-status - name: update-status
continue-on-error: true continue-on-error: true
@@ -67,12 +68,13 @@ jobs:
steps: steps:
# generated comment? # generated comment?
- uses: dawidd6/action-download-artifact@v2 - uses: dawidd6/action-download-artifact@v6
continue-on-error: true continue-on-error: true
with: with:
workflow: ${{github.event.workflow_run.name}} workflow: ${{github.event.workflow_run.name}}
run_id: ${{github.event.workflow_run.id}} run_id: ${{github.event.workflow_run.id}}
name: comment pattern: '{comment,comment-*}'
merge-multiple: true
path: comment path: comment
- name: update-comment - name: update-comment
continue-on-error: true continue-on-error: true
.github/workflows/test.yml
+6 -3
View File
@@ -709,19 +709,22 @@ jobs:
if: ${{github.event_name == 'pull_request'}} if: ${{github.event_name == 'pull_request'}}
continue-on-error: true continue-on-error: true
with: with:
name: sizes-x86_64 pattern: '{sizes,sizes-*}'
merge-multiple: true
path: sizes path: sizes
- uses: actions/download-artifact@v4.1.8 - uses: actions/download-artifact@v4.1.8
if: ${{github.event_name == 'pull_request'}} if: ${{github.event_name == 'pull_request'}}
continue-on-error: true continue-on-error: true
with: with:
name: cov pattern: '{cov,cov-*}'
merge-multiple: true
path: cov path: cov
- uses: actions/download-artifact@v4.1.8 - uses: actions/download-artifact@v4.1.8
if: ${{github.event_name == 'pull_request'}} if: ${{github.event_name == 'pull_request'}}
continue-on-error: true continue-on-error: true
with: with:
name: bench pattern: '{bench,bench-*}'
merge-multiple: true
path: bench path: bench
# try to find results from tests # try to find results from tests