Github/littlefs
1
Fork 0
Code Actions Activity

scripts: bench.py: Fixed issue where cumul results were mixed together

Browse Source 
Whoops, looks like cumulative results were overlooked when multiple
bench measurements per bench were added. We were just adding all
cumulative results together!

This led to some very confusing bench results.

The solution here is to keep track of per-measurement cumulative results
via a Python dict. Which adds some memory usage, but definitely not
enough to be noticeable in the context of the bench-runner.
This commit is contained in:
Christopher Haster
2025-05-15 16:16:41 -05:00
parent 48daeed509
commit 275ca0e0ec
1 changed files with 21 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files
scripts/bench.py
+21 -21
View File
@@ -1042,9 +1042,9 @@ def run_stage(name, runner, bench_ids, stdout_, trace_, output_, **args):
last_defines = None # fetched on demand
last_stdout = co.deque(maxlen=args.get('context', 5) + 1)
last_assert = None
readed_ = None
proged_ = None
erased_ = None
creaded = co.defaultdict(lambda: 0)
cproged = co.defaultdict(lambda: 0)
cerased = co.defaultdict(lambda: 0)
try:
while True:
# parse a line for state changes
@@ -1075,9 +1075,9 @@ def run_stage(name, runner, bench_ids, stdout_, trace_, output_, **args):
last_defines = None
last_stdout.clear()
last_assert = None
readed_ = 0
proged_ = 0
erased_ = 0
creaded.clear()
cproged.clear()
cerased.clear()
elif op == 'finished':
# force a failure
if args.get('fail'):
@@ -1110,13 +1110,13 @@ def run_stage(name, runner, bench_ids, stdout_, trace_, output_, **args):
return float(v)
else:
return int(v)
readed__ = dat(m.group('readed'))
proged__ = dat(m.group('proged'))
erased__ = dat(m.group('erased'))
readed_ = dat(m.group('readed'))
proged_ = dat(m.group('proged'))
erased_ = dat(m.group('erased'))
# keep track of cumulative measurements
readed_ += readed__
proged_ += proged__
erased_ += erased__
creaded[m_] += readed_
cproged[m_] += proged_
cerased[m_] += erased_
if output_:
# fetch defines if needed, only do this at most
# once per perm
@@ -1131,16 +1131,16 @@ def run_stage(name, runner, bench_ids, stdout_, trace_, output_, **args):
**last_defines,
'm': m_,
'n': n_,
'bench_readed': readed__,
'bench_proged': proged__,
'bench_erased': erased__,
'bench_creaded': readed_,
'bench_cproged': proged_,
'bench_cerased': erased_})
'bench_readed': readed_,
'bench_proged': proged_,
'bench_erased': erased_,
'bench_creaded': creaded[m_],
'bench_cproged': cproged[m_],
'bench_cerased': cerased[m_]})
# keep track of total for summary
readed += readed__
proged += proged__
erased += erased__
readed += readed_
proged += proged_
erased += erased_
except KeyboardInterrupt:
proc.kill()
raise BenchFailure(last_id, 0, list(last_stdout))