From 2402e108db8fa948b316e342696184a740f48f62 Mon Sep 17 00:00:00 2001 From: Christopher Haster Date: Thu, 6 Jun 2024 17:42:45 -0500 Subject: [PATCH] Reduced test_powerloss OPS from 1024 -> 256 Now that we are testing more powerloss behaviors, test_powerloss is the longest running test suite by a decent margin: Before: $ ./scripts/summary.py test.csv -bsuite -ftime -Stime ... snip ... test_rbyd 578.6 test_fwrite 984.5 test_badblocks 1341.5 test_exhaustion 1648.3 test_powerloss 2192.3 <-- TOTAL 7378.6 $ ./scripts/summary.py test.csv -bcase -ftime -Stime ... snip ... test_fwrite_fuzz_aligned 247.2 test_exhaustion_file_fuzz 287.7 test_exhaustion_dir_fuzz 307.2 test_exhaustion_orphanzombie_fuzz 389.1 test_exhaustion_orphanzombiedir_fuzz 531.5 test_powerloss_file_pl_fuzz 787.7 <-- test_badblocks_single_dir_many 840.2 test_powerloss_filedir_pl_fuzz 1366.7 <-- TOTAL 7378.6 But testing more things is better than testing the same thing more. Worst case you can always manually override OPS, -DOPS=1024, if you have CI cycles to spare. Though note with our linear powerloss heuristic, the tail end of long running tests also recieves fewer powerlosses, which reduces the usefulness of running these tests longer. These *_pl_fuzz tests also now match the default number of OPS in test_relocations. --- tests/test_powerloss.toml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/test_powerloss.toml b/tests/test_powerloss.toml index dd1a8d2a..b73090a4 100644 --- a/tests/test_powerloss.toml +++ b/tests/test_powerloss.toml @@ -216,7 +216,7 @@ defines.POWERLOSS_BEHAVIOR = [ # inlining has a tendency to hide sync issues, so try without defines.INLINE_SIZE = ['BLOCK_SIZE/4', '0'] defines.N = [1, 2, 4, 8, 16, 32, 64] -defines.OPS = 1024 +defines.OPS = 256 defines.SIZE = [ '0', 'FILE_BUFFER_SIZE/2', @@ -444,7 +444,7 @@ defines.INLINE_SIZE = ['BLOCK_SIZE/4', '0'] # note dirs x files grows O(n^2) defines.N = [1, 2, 4, 8] defines.M = 'N' -defines.OPS = 1024 +defines.OPS = 256 defines.SIZE = [ '0', 'FILE_BUFFER_SIZE/2',