Limited file->leaf to reads + erased-state caching
This reverts most of the lazy-grafting/crystallization logic, but keeps
the general crystallization algorithm rewrite and file->leaf for caching
read operations and erased-state.
Unfortunately lazy-grafting/crystallization is both a code and stack
heavy feature for a relatively specific write pattern. It doesn't even
help if we're forced to write fragments due to prog alignment.
Dropping lazy-grafting/crystallization trades off linear write/rewrite
performance for code and stack savings:
code stack ctx
before: 37084 2304 636
after: 36428 (-1.8%) 2248 (-2.4%) 636 (+0.0%)
But with file->leaf we still keep the improvements to linear read
performance!
Compared to pre-file->leaf:
code stack ctx
before file->leaf: 36016 2296 636
after lazy file->leaf: 37084 (+3.0%) 2304 (+0.3%) 636 (+0.0%)
after eager file->leaf: 36428 (+1.1%) 2248 (-2.1%) 636 (+0.0%)
I'm still on the fence about this, but lazy-grafting/crystallization is
just a lot of code... And the first 6 letters of littlefs don't spell
"speedy" last time I checked...
At the very least we can always add lazy-grafting/crystallization as an
opt-in write strategy later.
This commit is contained in:
@@ -144,8 +144,6 @@ enum lfs_type {
|
||||
|
||||
// internally used flags, don't use these
|
||||
#define LFS_o_TYPE 0xf0000000 // The file's type
|
||||
#define LFS_o_UNCRYST 0x00400000 // File's leaf not fully crystallized
|
||||
#define LFS_o_UNGRAFT 0x00800000 // File's leaf does not match bshrub/btree
|
||||
#define LFS_o_UNFLUSH 0x01000000 // File's data does not match disk
|
||||
#define LFS_o_UNSYNC 0x02000000 // File's metadata does not match disk
|
||||
#define LFS_o_UNCREAT 0x04000000 // File does not exist yet
|
||||
|
||||
Reference in New Issue
Block a user