Reworked internal tests remove unnecessary shim functions

These shims, originally intended to remap the tests to new internal
APIs without a significant rewrite, are a long-outstanding piece of
technical debt. Now that the internal API is more stable, it's time for
that rewrite.

Reasons for not keeping the internal shims:

- They add more complexity to the test suites.
- They come with (out-of-date) constraints that limit what we can test.
- It's more difficult to debug test failures, with 2 layers and all.

I ended up writing a small tree editor out of tree to do most of this
rewrite.

Did it save time? Probably not. But it was quite a bit more fun than
manaully rewriting ~21K lines of code.
This commit is contained in:
Christopher Haster
2024-02-02 15:15:23 -06:00
parent 921fe2ba1b
commit 204f46a131
3 changed files with 1765 additions and 1423 deletions
+630 -604
View File
File diff suppressed because it is too large Load Diff
+296 -265
View File
File diff suppressed because it is too large Load Diff
+839 -554
View File
File diff suppressed because it is too large Load Diff