Replaced REMOUNT with small post-test loops where possible

Browse Source

We've been wasting a lot of test cycles thanks to REMOUNT. Using a test
define for this effectively duplicates the test, when we really just
want to run more post-test code without additional mutation.

The main reason for REMOUNT has been to save typing, which, well, is not
a bad reason, these tests involve a lot of typing...

But this is probably a hammer/nail situation. If we replace these with a
small post-test loop, we can save quite a bit of time:

  make test -j before: 5791.9s
  make test -j after:  5123.8s (-11.5%)

Some tests still use a REMOUNT define, but these should be limited to
cases where remount actually changes the test's behavior.

...

This commit is contained in:

Christopher Haster

2024-05-28 03:10:03 -05:00

parent 76d3c49b5c

commit 1c363b428a

6 changed files with 4781 additions and 4657 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

tests/test_fwrite.toml

+679 -623

File diff suppressed because it is too large Load Diff