Github/littlefs
1
Fork 0
Code Actions Activity

Dropped LFS3_FORCEINLINE from lfs3_data_slice

Browse Source 
This use to save code/stack, but apparently not anymore:

                            code          stack          ctx
  before:                  36960           2392          652
  after:                   36936 (-0.1%)   2384 (-0.3%)  652 (+0.0%)

                            code          stack          ctx
  ckdatacksumreads before: 38368           2720          660
  ckdatacksumreads after:  38024 (-0.9%)   2624 (-3.5%)  660 (+0.0%)

The stack hot-path has changed significantly since then, with many
functions adopting LFS3_NOINLINE to get off the stack hot-path. Not sure
if that's related.

I'm also starting to think LFS3_FORCEINLINE is a symptom of
over-optimization. We shouldn't be doing the compilers job, if it can't
figure out the best inlining strategy so be it.
This commit is contained in:
Christopher Haster
2025-07-16 13:59:00 -05:00
parent dbad3e6863
commit 17cefcdd42
1 changed files with 0 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lfs3.c
-1
View File
@@ -1641,7 +1641,6 @@ static inline uint32_t lfs3_data_cksum(lfs3_data_t data) {
#endif #endif
// data slicing // data slicing
LFS3_FORCEINLINE
static inline lfs3_data_t lfs3_data_slice(lfs3_data_t data, static inline lfs3_data_t lfs3_data_slice(lfs3_data_t data,
lfs3_ssize_t off, lfs3_ssize_t size) { lfs3_ssize_t off, lfs3_ssize_t size) {
// limit our off/size to data range, note the use of unsigned casts // limit our off/size to data range, note the use of unsigned casts