scripts: Reduced table name widths to 8 chars minimum
I still think the 24 (23+1) char minimum is a good default for 2 column
output such as help text, especially if you don't have automatic width
detection. But our result scripts need to be a bit more flexible.
Consider:
$ make summary
code data stack structs
TOTAL 68864 0 3744 1520
Vs:
$ make summary
code data stack structs
TOTAL 68864 0 3744 1520
Up until now we were just kind of working around this with cut -c 25- in
our Makefile, but now that our result scripts automatically scale the
table widths, they should really just default to whatever is the most
useful.
This commit is contained in:
@@ -352,8 +352,7 @@ summary sizes: \
|
|||||||
<(./scripts/csv.py $(BUILDDIR)/lfs.structs.csv \
|
<(./scripts/csv.py $(BUILDDIR)/lfs.structs.csv \
|
||||||
-fstructs=size -q $(SUMMARYFLAGS) -o-) \
|
-fstructs=size -q $(SUMMARYFLAGS) -o-) \
|
||||||
-bfunction -fcode -fdata -fstack='max(stack)' -fstructs \
|
-bfunction -fcode -fdata -fstack='max(stack)' -fstructs \
|
||||||
-Y $(SUMMARYFLAGS) \
|
-Y $(SUMMARYFLAGS))
|
||||||
| cut -c 25-)
|
|
||||||
|
|
||||||
## Compare compile-time sizes
|
## Compare compile-time sizes
|
||||||
.PHONY: summary-diff sizes-diff
|
.PHONY: summary-diff sizes-diff
|
||||||
@@ -383,8 +382,7 @@ summary-diff sizes-diff: $(OBJ) $(CI)
|
|||||||
<(./scripts/csv.py $(BUILDDIR)/lfs.structs.csv \
|
<(./scripts/csv.py $(BUILDDIR)/lfs.structs.csv \
|
||||||
-fstructs=size -q $(SUMMARYFLAGS) -o-) \
|
-fstructs=size -q $(SUMMARYFLAGS) -o-) \
|
||||||
-fcode -fdata -fstack='max(stack)' -fstructs \
|
-fcode -fdata -fstack='max(stack)' -fstructs \
|
||||||
-q $(SUMMARYFLAGS) -o-) \
|
-q $(SUMMARYFLAGS) -o-))
|
||||||
| cut -c 25-)
|
|
||||||
|
|
||||||
## Build the test-runner
|
## Build the test-runner
|
||||||
.PHONY: test-runner build-tests
|
.PHONY: test-runner build-tests
|
||||||
|
|||||||
+1
-1
@@ -524,7 +524,7 @@ def table(Result, results, diff_results=None, *,
|
|||||||
|
|
||||||
# find the best widths, note that column 0 contains the names and is
|
# find the best widths, note that column 0 contains the names and is
|
||||||
# handled a bit differently
|
# handled a bit differently
|
||||||
widths = co.defaultdict(lambda: 7, {0: 23})
|
widths = co.defaultdict(lambda: 7, {0: 7})
|
||||||
notes = co.defaultdict(lambda: 0)
|
notes = co.defaultdict(lambda: 0)
|
||||||
for line in lines:
|
for line in lines:
|
||||||
for i, x in enumerate(line):
|
for i, x in enumerate(line):
|
||||||
|
|||||||
+1
-1
@@ -534,7 +534,7 @@ def table(Result, results, diff_results=None, *,
|
|||||||
|
|
||||||
# find the best widths, note that column 0 contains the names and is
|
# find the best widths, note that column 0 contains the names and is
|
||||||
# handled a bit differently
|
# handled a bit differently
|
||||||
widths = co.defaultdict(lambda: 7, {0: 23})
|
widths = co.defaultdict(lambda: 7, {0: 7})
|
||||||
notes = co.defaultdict(lambda: 0)
|
notes = co.defaultdict(lambda: 0)
|
||||||
for line in lines:
|
for line in lines:
|
||||||
for i, x in enumerate(line):
|
for i, x in enumerate(line):
|
||||||
|
|||||||
+1
-1
@@ -1341,7 +1341,7 @@ def table(Result, results, diff_results=None, *,
|
|||||||
|
|
||||||
# find the best widths, note that column 0 contains the names and is
|
# find the best widths, note that column 0 contains the names and is
|
||||||
# handled a bit differently
|
# handled a bit differently
|
||||||
widths = co.defaultdict(lambda: 7, {0: 23})
|
widths = co.defaultdict(lambda: 7, {0: 7})
|
||||||
notes = co.defaultdict(lambda: 0)
|
notes = co.defaultdict(lambda: 0)
|
||||||
for line in lines:
|
for line in lines:
|
||||||
for i, x in enumerate(line):
|
for i, x in enumerate(line):
|
||||||
|
|||||||
+1
-1
@@ -524,7 +524,7 @@ def table(Result, results, diff_results=None, *,
|
|||||||
|
|
||||||
# find the best widths, note that column 0 contains the names and is
|
# find the best widths, note that column 0 contains the names and is
|
||||||
# handled a bit differently
|
# handled a bit differently
|
||||||
widths = co.defaultdict(lambda: 7, {0: 23})
|
widths = co.defaultdict(lambda: 7, {0: 7})
|
||||||
notes = co.defaultdict(lambda: 0)
|
notes = co.defaultdict(lambda: 0)
|
||||||
for line in lines:
|
for line in lines:
|
||||||
for i, x in enumerate(line):
|
for i, x in enumerate(line):
|
||||||
|
|||||||
+1
-1
@@ -933,7 +933,7 @@ def table(Result, results, diff_results=None, *,
|
|||||||
|
|
||||||
# find the best widths, note that column 0 contains the names and is
|
# find the best widths, note that column 0 contains the names and is
|
||||||
# handled a bit differently
|
# handled a bit differently
|
||||||
widths = co.defaultdict(lambda: 7, {0: 23})
|
widths = co.defaultdict(lambda: 7, {0: 7})
|
||||||
notes = co.defaultdict(lambda: 0)
|
notes = co.defaultdict(lambda: 0)
|
||||||
for line in lines:
|
for line in lines:
|
||||||
for i, x in enumerate(line):
|
for i, x in enumerate(line):
|
||||||
|
|||||||
+1
-1
@@ -897,7 +897,7 @@ def table(Result, results, diff_results=None, *,
|
|||||||
|
|
||||||
# find the best widths, note that column 0 contains the names and is
|
# find the best widths, note that column 0 contains the names and is
|
||||||
# handled a bit differently
|
# handled a bit differently
|
||||||
widths = co.defaultdict(lambda: 7, {0: 23})
|
widths = co.defaultdict(lambda: 7, {0: 7})
|
||||||
notes = co.defaultdict(lambda: 0)
|
notes = co.defaultdict(lambda: 0)
|
||||||
for line in lines:
|
for line in lines:
|
||||||
for i, x in enumerate(line):
|
for i, x in enumerate(line):
|
||||||
|
|||||||
+1
-1
@@ -579,7 +579,7 @@ def table(Result, results, diff_results=None, *,
|
|||||||
|
|
||||||
# find the best widths, note that column 0 contains the names and is
|
# find the best widths, note that column 0 contains the names and is
|
||||||
# handled a bit differently
|
# handled a bit differently
|
||||||
widths = co.defaultdict(lambda: 7, {0: 23})
|
widths = co.defaultdict(lambda: 7, {0: 7})
|
||||||
notes = co.defaultdict(lambda: 0)
|
notes = co.defaultdict(lambda: 0)
|
||||||
for line in lines:
|
for line in lines:
|
||||||
for i, x in enumerate(line):
|
for i, x in enumerate(line):
|
||||||
|
|||||||
+1
-1
@@ -474,7 +474,7 @@ def table(Result, results, diff_results=None, *,
|
|||||||
|
|
||||||
# find the best widths, note that column 0 contains the names and is
|
# find the best widths, note that column 0 contains the names and is
|
||||||
# handled a bit differently
|
# handled a bit differently
|
||||||
widths = co.defaultdict(lambda: 7, {0: 23})
|
widths = co.defaultdict(lambda: 7, {0: 7})
|
||||||
notes = co.defaultdict(lambda: 0)
|
notes = co.defaultdict(lambda: 0)
|
||||||
for line in lines:
|
for line in lines:
|
||||||
for i, x in enumerate(line):
|
for i, x in enumerate(line):
|
||||||
|
|||||||
Reference in New Issue
Block a user