Github/littlefs
1
Fork 0
Code Actions Activity

Limited byte-level tests to native testing due to time

Browse Source 
Byte-level writes are expensive and not suggested (caches >= 4 bytes
make much more sense), however there are many corner cases with
byte-level writes that can be easy to miss (power-loss leaving single
bytes written to disk).

Unfortunately, byte-level writes mixed with power-loss testing, the
Travis infrastructure, and Arm Thumb instruction set simulation
exceeds the 50-minute budget Travis allocates for jobs.

For now I'm disabling the byte-level tests under Qemu, with the hope that
performance improvements in littlefs will let us turn these tests back
on in the future.
This commit is contained in:
Christopher Haster
2020-02-18 11:35:22 -06:00
parent d04b077506
commit 0990296619
2 changed files with 12 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.travis.yml
+12 -6
View File
@@ -115,7 +115,7 @@ jobs:
env: env:
- NAME=littlefs-arm - NAME=littlefs-arm
- CC="arm-linux-gnueabi-gcc --static -mthumb" - CC="arm-linux-gnueabi-gcc --static -mthumb"
- TFLAGS="$TFLAGS -e qemu-arm" - TFLAGS="$TFLAGS --exec=qemu-arm"
install: install:
- *install-common - *install-common
- sudo apt-get install - sudo apt-get install
@@ -131,7 +131,9 @@ jobs:
- {<<: *arm, script: [*test-nand, *report-size]} - {<<: *arm, script: [*test-nand, *report-size]}
- {<<: *arm, script: [*test-no-intrinsics, *report-size]} - {<<: *arm, script: [*test-no-intrinsics, *report-size]}
- {<<: *arm, script: [*test-no-inline, *report-size]} - {<<: *arm, script: [*test-no-inline, *report-size]}
- {<<: *arm, script: [*test-byte-writes, *report-size]} # it just takes way to long to run byte-level writes in qemu,
# note this is still tested in the native tests
#- {<<: *arm, script: [*test-byte-writes, *report-size]}
- {<<: *arm, script: [*test-block-cycles, *report-size]} - {<<: *arm, script: [*test-block-cycles, *report-size]}
- {<<: *arm, script: [*test-odd-block-count, *report-size]} - {<<: *arm, script: [*test-odd-block-count, *report-size]}
- {<<: *arm, script: [*test-odd-block-size, *report-size]} - {<<: *arm, script: [*test-odd-block-size, *report-size]}
@@ -142,7 +144,7 @@ jobs:
env: env:
- NAME=littlefs-mips - NAME=littlefs-mips
- CC="mips-linux-gnu-gcc --static" - CC="mips-linux-gnu-gcc --static"
- TFLAGS="$TFLAGS -e qemu-mips" - TFLAGS="$TFLAGS --exec=qemu-mips"
install: install:
- *install-common - *install-common
- sudo apt-get install - sudo apt-get install
@@ -158,7 +160,9 @@ jobs:
- {<<: *mips, script: [*test-nand, *report-size]} - {<<: *mips, script: [*test-nand, *report-size]}
- {<<: *mips, script: [*test-no-intrinsics, *report-size]} - {<<: *mips, script: [*test-no-intrinsics, *report-size]}
- {<<: *mips, script: [*test-no-inline, *report-size]} - {<<: *mips, script: [*test-no-inline, *report-size]}
- {<<: *mips, script: [*test-byte-writes, *report-size]} # it just takes way to long to run byte-level writes in qemu,
# note this is still tested in the native tests
#- {<<: *mips, script: [*test-byte-writes, *report-size]}
- {<<: *mips, script: [*test-block-cycles, *report-size]} - {<<: *mips, script: [*test-block-cycles, *report-size]}
- {<<: *mips, script: [*test-odd-block-count, *report-size]} - {<<: *mips, script: [*test-odd-block-count, *report-size]}
- {<<: *mips, script: [*test-odd-block-size, *report-size]} - {<<: *mips, script: [*test-odd-block-size, *report-size]}
@@ -169,7 +173,7 @@ jobs:
env: env:
- NAME=littlefs-powerpc - NAME=littlefs-powerpc
- CC="powerpc-linux-gnu-gcc --static" - CC="powerpc-linux-gnu-gcc --static"
- TFLAGS="$TFLAGS -e qemu-ppc" - TFLAGS="$TFLAGS --exec=qemu-ppc"
install: install:
- *install-common - *install-common
- sudo apt-get install - sudo apt-get install
@@ -185,7 +189,9 @@ jobs:
- {<<: *powerpc, script: [*test-nand, *report-size]} - {<<: *powerpc, script: [*test-nand, *report-size]}
- {<<: *powerpc, script: [*test-no-intrinsics, *report-size]} - {<<: *powerpc, script: [*test-no-intrinsics, *report-size]}
- {<<: *powerpc, script: [*test-no-inline, *report-size]} - {<<: *powerpc, script: [*test-no-inline, *report-size]}
- {<<: *powerpc, script: [*test-byte-writes, *report-size]} # it just takes way to long to run byte-level writes in qemu,
# note this is still tested in the native tests
#- {<<: *powerpc, script: [*test-byte-writes, *report-size]}
- {<<: *powerpc, script: [*test-block-cycles, *report-size]} - {<<: *powerpc, script: [*test-block-cycles, *report-size]}
- {<<: *powerpc, script: [*test-odd-block-count, *report-size]} - {<<: *powerpc, script: [*test-odd-block-count, *report-size]}
- {<<: *powerpc, script: [*test-odd-block-size, *report-size]} - {<<: *powerpc, script: [*test-odd-block-size, *report-size]}
tests/test_dirs.toml
-2
View File
@@ -157,7 +157,6 @@ code = '''
[[case]] # reentrant many directory creation/rename/removal [[case]] # reentrant many directory creation/rename/removal
define.N = [5, 11] define.N = [5, 11]
reentrant = true reentrant = true
if = 'LFS_CACHE_SIZE >= 4' # these just take too long with byte-level writes
code = ''' code = '''
err = lfs_mount(&lfs, &cfg); err = lfs_mount(&lfs, &cfg);
if (err) { if (err) {
@@ -384,7 +383,6 @@ code = '''
[[case]] # reentrant file creation/rename/removal [[case]] # reentrant file creation/rename/removal
define.N = [5, 25] define.N = [5, 25]
reentrant = true reentrant = true
if = 'LFS_CACHE_SIZE >= 4' # these just take too long with byte-level writes
code = ''' code = '''
err = lfs_mount(&lfs, &cfg); err = lfs_mount(&lfs, &cfg);
if (err) { if (err) {